CK II - [3.0.1] Inconsistency between the candidate_trigger for princely and feudal elective

[Tatterhood]

One line summary of your issue
[3.0.1] Inconsistency between the candidate_trigger for princely and feudal elective

Game Version
3.0.1

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
I was looking in the succession voting code in response to someone else's question and noticed this small but significant difference (inside a NOR block, so these are conditions excluding someone from eligibility):

               # Feudal elective
               mother = {
                   is_alive = yes
                   is_married = ROOT
                   parent_for_elective_succession_trigger = yes
               }
               father = {
                   is_alive = yes
                   is_married = ROOT
                   parent_for_elective_succession_trigger = yes
               }

vs.

               # Princely elective
               mother = {
                   is_alive = yes
                   NOT = { is_married = ROOT }
                   parent_for_elective_succession_trigger = yes
               }
               father = {
                   is_alive = yes
                   NOT = { is_married = ROOT }
                   parent_for_elective_succession_trigger = yes
               }

The princely version makes an exception to the "can't nominate someone whose parent is eligible" logic when the parent is married to the ruler, whereas the feudal elective version applies only in that case. I suspect the princely version is the intended behaviour in both cases, and the missing NOTs here are the cause of (at least some of) the issues with people being unable to nominate their children under feudal elective.

Steps to reproduce the issue.


Upload Attachment

 

[jruderman]

I noticed this too and agree with your analysis. However, I think it's weird that it's checking marriage at all! A divorce shouldn't change my child's eligibility, and marrying a vassal shouldn't change the eligibility of their other children.

Instead, both succession methods should be changed to check parentage directly:

    OR = {
        is_child_of = ROOT  # Candidate is the ruler's child
        NOR = {
            mother = {
                is_alive = yes
                parent_for_elective_succession_trigger = yes
            }
            father = {
                is_alive = yes
                parent_for_elective_succession_trigger = yes
            }
        }
    }

 

[Tatterhood]

I noticed this too and agree with your analysis. However, I think it's weird that it's checking marriage at all! A divorce shouldn't change my child's eligibility, and marrying a vassal shouldn't change the eligibility of their other children.

Instead, both succession methods should be changed to check parentage directly:

    OR = {
        is_child_of = ROOT  # Candidate is the ruler's child
        NOR = {
            mother = {
                is_alive = yes
                parent_for_elective_succession_trigger = yes
            }
            father = {
                is_alive = yes
                parent_for_elective_succession_trigger = yes
            }
        }
    }

Yeah I agree, it's weird that "parent is currently married to the ruler" is the check rather than something else like that. I thought about suggesting such a change but figured I'd keep it to the specific bug.

While we're at it, if the point is to prevent skipping a generation by nominating someone with an eligible parent, it probably should take gender laws into account in terms of which parent it checks. Unless I'm missing something it looks to me like it will prevent you from "skipping" the mother even under strict agnatic. (And even under agnatic-cognatic, maternal grandsons would inherit ahead of their mothers in primo so it's weird for them to be ineligible in elective.)

 

[redtide]

Note that the "fix" was just to comment out the preference for parents altogether:

           NOR = {
               #mother = {         # Uncommenting this condition provokes that a ruler's son is not a valid candidate if the mother is married to the ruler and a candidate
               #   is_alive = yes
               #   is_married = ROOT
               #   parent_for_elective_succession_trigger = yes
               #}
               #father = {           # Same as above, for the father
               #   is_alive = yes
               #   is_married = ROOT
               #   parent_for_elective_succession_trigger = yes
               #}