CK II - [3.3.4] history.cpp: major_revolt cb created temporary title not correctly destroyed before/after a war.

[Aerotinge]

One line summary of your issue
[3.3.4] history.cpp: major_revolt cb created temporary title not correctly destroyed before/after the war timeframe.

Game Version
3.3.4 [SOHY]

What expansions do you have installed?


Do you have mods enabled?
Yes

Please explain your issue is in as much detail as possible.
History civil war modding having problem in many aspect. This one shows a temporary title created by major_revolt(faction-based) cb go on with holder after war, or even before the war if scroll back the date.

Steps to reproduce the issue.
1. Create a history war, for example

name = "Rebel war"

casus_belli = {
    casus_belli = claim_on_liege_plot
    actor = 141212
    recipient = 141232
    landed_title = e_nippon
    date = 1183.9.24
}

# In civil wars defender MUST be added before attacker!
1183.9.24 = {
    add_defender = 141232
    add_attacker = 141212
    start_war = yes
    add_attacker = 141431
    add_attacker = 141432
    vassal_liege = {
        vassal = 141212
        liege = 141232
    }
    vassal_liege = {
        vassal = 141431
        liege = 141232
    }
    vassal_liege = {
        vassal = 141432
        liege = 141232
    }
}
1185.3.24 = {
    end_war = yes
    rem_attacker = 141212
    rem_attacker = 141431
    rem_attacker = 141432
    rem_defender = 141232
}

While all attacker are landed vassals of defender before rebel.

2. Start a game, in character selection screen, scroll the date beyond 1185.3.24, the war has ended. But the revolt title is still held by actor(141212).

3. Now roll back the date before 1183.9.24, the war should be not yet fired. But the actor already hold that rebel title!
4. (Optional) By roll the date back and forth this timeframe, you could get a character with tons of rebel title which won't get destoryed.

QA staff have died out I guess, anyway this is for you Paradox and an elegy for your old, legacy code.

Upload Attachment
File(s) attached

It's 1175.1.27 and he holds two temporary titles create on 1183.9.24, wow.