CK II - Great Harbour Peirs tax %

[Sunsanvil]

One line summary of your issue
Great Harbour Peirs tax %

Game Version
3.2.1

What expansions do you have installed?
Jade Dragon,
Monks & Mystics,
The Reapers Due,
Conclave,
Horse Lords,
Way of Life,
Charlemagne,
Rajas of India,
Sons of Abraham,
The Old Gods,
The Republic,
Legacy of Rome,
Sword of Islam,
Holy Fury, All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
In-game, Piers is reported as having just a 0.2% tax gain. The code puts it at 0.25%.

upgrade_piers = { # Piers
    picture = GFX_upgrade_icon_anchor
   
    potential = { }
    allow = { }
    active = { }

    flags = {
        is_plural
    }
    build_time = 24
    gold_cost_flat = 450
    gold_cost_ticking = 1
    local_modifier = {
        tradevalue = 30
        supply_limit = 0.25
        local_tax_modifier = 0.0025
    }
}

The Wiki quotes it as 2.5% (which is in line with other Great Harbor features) so I'm guessing that its the game code which has the typo.

Steps to reproduce the issue.


Upload Attachment

 

[voodoofan]

Ingame numbers are sometimes rounded down. So your effect does 0.25% but it only shows 0.2%. (But it's really 0.25%)

When you get the next stage, it will show 0.5%.

 

[Sunsanvil]

Its less an issue of 0.2 vs 0.25, and more one of: It should probably be 2.5 (as reported in the wiki, putting it more in line with other gw features).

 

[voodoofan]

It is 0.25, but the displayed value is rounded down.

 

[Sunsanvil]

Again, what it currently is was never in question.

Rather, I believe that it is a bug/error and that it should be 2.5%.

 

[voodoofan]

Again, what it currently is was never in question.

Rather, I believe that it is a bug/error and that it should be 2.5%.

It's not a bug. Fort level and many other things are also rounded down, for an easier view.

 

[Sunsanvil]

This is not about rounding anything. Rather, the posited error is that there is, literally, a typo in the code: an extra 0 which shouldn't be there. The line "local_tax_modifier =" was probably meant to be 0.025 (not 0.0025).

 

[Rockphed]

This is not about rounding anything. Rather, the posited error is that there is, literally, a typo in the code: an extra 0 which shouldn't be there. The line "local_tax_modifier =" was probably meant to be 0.025 (not 0.0025).

In other words, this isn't so much a technical bug (the game works) as a balance or design bug (the piers are a significantly less useful harbor feature than the other income boosting features). 30 trade value is nice, but it doesn't make up for 2.25% tax income.