Conquest of the Desert Journal Entry only adds homeland to one of two states, no homelands after changing from Platinean or South Andean

[Giulls]

Integrity​

I have verified my game files (on Steam)​

Yes

I have disabled all mods​

Yes

Required​

Summary​

Conquest of the Desert Journal Entry only adds homeland to one of two states, no homelands after changing from Platinean or South Andean

Description​

The Conquest of the Desert journal entry applies to any Platinean or South Andean nation bordering Patagonia that has a colonization law active, usually Argentina and Chile, but potentially Paraguay, Uruguay, Peru, or Bolivia. The Journal Entry completes when Patagonia and Araucania are each owned by a single country of South Andean or Platinean culture. The journal entry has two issues:
1. When the journal entry completes it adds a cultural homeland of the country's primary culture to Araucania if fully owned by the nation, and if not, it adds a cultural homeland of the country's primary culture to Patagonia. The if / else block here is problematic - if a country owns both Araucania and Patagonia fully, they only gain a homeland over Araucania because of the if / else logic, and cannot ever gain a homeland on Patagonia.
2. If a nation changes culture from Platinean or South Andean they lose the ability to gain a homeland because the journal entry and corresponding event only checks for Platinean and South Andean. A country is more likely to research nationalism and change its culture before it is able to finish colonizing all the lands.

A related issue that is not directly related to this issue is that Chile colonizes Araucania much, much, much faster than Argentina colonizes all the states they are colonizing, so Chile gets both Araucania and Patagonia every game, before Argentina even starts on Patagonia.

Steps to reproduce​

Issue 1: Fully own both Araucania and Patagonia as Chile or Argentina.
Issue 2: Change culture from Platinean or South Andean to Argentine, Chilean, Uruguayan or Paraguayan through je_south_american_national_identity_emergence

Game Version​

1.8.6

OS​

Windows

Additional​

Bug Type​

Other

Save Game​

Attachments​

Player Pain​

3

 

[Giulls]

I am including a fix for the journal entry and related events that properly checks for all the possible Platinean and South Andean derivative cultures, and properly checks for owning both states:

je_patagonia = {
    icon = "gfx/interface/icons/event_icons/event_military.dds"

    group = je_group_historical_content

    is_shown_when_inactive = {
        exists = c:PAT
        any_neighbouring_state = {
            owner = c:PAT
        }
        OR = {
            country_has_primary_culture = cu:south_andean
            country_has_primary_culture = cu:platinean
            country_has_primary_culture = cu:chilean
            country_has_primary_culture = cu:argentine
            country_has_primary_culture = cu:uruguayan
            country_has_primary_culture = cu:paraguayan
        }
    }

    scripted_button = patagonia_button

    possible = {
        NOT = { has_law = law_type:law_no_colonial_affairs }
    }

    complete = {
        AND = {
            any_country = {
                OR = {
                    country_has_primary_culture = cu:south_andean
                    country_has_primary_culture = cu:platinean
                    country_has_primary_culture = cu:chilean
                    country_has_primary_culture = cu:argentine
                    country_has_primary_culture = cu:uruguayan
                    country_has_primary_culture = cu:paraguayan
                }
                owns_entire_state_region = STATE_ARAUCANIA
            }  
            any_country = {
                OR = {
                    country_has_primary_culture = cu:south_andean
                    country_has_primary_culture = cu:platinean
                    country_has_primary_culture = cu:chilean
                    country_has_primary_culture = cu:argentine
                    country_has_primary_culture = cu:uruguayan
                    country_has_primary_culture = cu:paraguayan
                }
                owns_entire_state_region = STATE_PATAGONIA
            }
            any_country = {
                OR = {
                    country_has_primary_culture = cu:south_andean
                    country_has_primary_culture = cu:platinean
                    country_has_primary_culture = cu:chilean
                    country_has_primary_culture = cu:argentine
                    country_has_primary_culture = cu:uruguayan
                    country_has_primary_culture = cu:paraguayan
                }
                owns_entire_state_region = STATE_RIO_NEGRO
            }
        }
    }

    on_complete = {
        trigger_event = { id = patagonia.1 }
    }

    on_monthly_pulse = {
        random_events = {
            85 = 0
            10 = patagonia.2
            5 = bp1_patagonia.1
        }
    }

    weight = 20
}

namespace = patagonia

# Patagonia JE completion
patagonia.1 = {
    type = country_event
    placement = ROOT

    title = patagonia.1.t
    desc = patagonia.1.d
    flavor = patagonia.1.f

    duration = 3

    event_image = {
        video = "southamerica_aristocrats"
    }

    on_created_soundeffect = "event:/SFX/UI/Alerts/event_appear"

    icon = "gfx/interface/icons/event_icons/event_military.dds"

    trigger = {
        # complete je_patagonia
    }

    immediate = {
       
    }

    option = {
        name = patagonia.1.a
        default_option = yes
        if = {
            limit = {
                owns_entire_state_region = STATE_ARAUCANIA
                country_has_primary_culture = cu:south_andean
            }
            s:STATE_ARAUCANIA = {
                add_homeland = cu:south_andean
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_ARAUCANIA
                country_has_primary_culture = cu:platinean
            }
            s:STATE_ARAUCANIA = {
                add_homeland = cu:platinean
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_ARAUCANIA
                country_has_primary_culture = cu:argentine
            }
            s:STATE_ARAUCANIA = {
                add_homeland = cu:argentine
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_ARAUCANIA
                country_has_primary_culture = cu:chilean
            }
            s:STATE_ARAUCANIA = {
                add_homeland = cu:chilean
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_ARAUCANIA
                country_has_primary_culture = cu:uruguayan
            }
            s:STATE_ARAUCANIA = {
                add_homeland = cu:uruguayan
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_ARAUCANIA
                country_has_primary_culture = cu:paraguayan
            }
            s:STATE_ARAUCANIA = {
                add_homeland = cu:paraguayan
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_PATAGONIA
                country_has_primary_culture = cu:platinean
            }
            s:STATE_PATAGONIA = {
                add_homeland = cu:platinean
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_PATAGONIA
                country_has_primary_culture = cu:south_andean
            }
            s:STATE_PATAGONIA = {
                add_homeland = cu:south_andean
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_PATAGONIA
                country_has_primary_culture = cu:argentine
            }
            s:STATE_PATAGONIA = {
                add_homeland = cu:argentine
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_PATAGONIA
                country_has_primary_culture = cu:chilean
            }
            s:STATE_PATAGONIA = {
                add_homeland = cu:chilean
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_PATAGONIA
                country_has_primary_culture = cu:uruguayan
            }
            s:STATE_PATAGONIA = {
                add_homeland = cu:uruguayan
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
        if = {
            limit = {
                owns_entire_state_region = STATE_PATAGONIA
                country_has_primary_culture = cu:paraguayan
            }
            s:STATE_PATAGONIA = {
                add_homeland = cu:paraguayan
                add_modifier = {
                    name = patagonian_settlement
                    months = long_modifier_time
                }
            }
        }
    }
}

patagonia.2 = {
    type = country_event
    placement = ROOT

    title = patagonia.2.t
    desc = patagonia.2.d
    flavor = patagonia.2.f

    duration = 3
    cooldown = { months = long_modifier_time }

    event_image = {
        video = "europenorthamerica_native_american"
    }

    on_created_soundeffect = "event:/SFX/UI/Alerts/event_appear"

    icon = "gfx/interface/icons/event_icons/event_military.dds"

    trigger = {
        any_scope_state = {
            is_incorporated = no
            any_neighbouring_state = {
                owner = {
                    is_country_type = decentralized
                    NOT = {
                        has_modifier = patagonia_supplied_with_weapons
                    }
                }
            }
        }
        any_country = {
            has_diplomatic_pact = {
                who = ROOT
                type = rivalry
            }
        }
    }

    immediate = {
        random_scope_state = {
            limit = {
                is_incorporated = no
                any_neighbouring_state = {
                    owner = {
                        is_country_type = decentralized
                    }
                    NOT = {
                        has_modifier = patagonia_supplied_with_weapons
                    }
                }
            }
            save_scope_as = patagonia_state
            random_neighbouring_state = {
                limit = {
                    owner = {
                        is_country_type = decentralized
                    }
                }
                owner = {
                    save_scope_as = patagonia_country
                }
            }
        }
        random_country = {
            limit = {
                has_diplomatic_pact = {
                    who = ROOT
                    type = rivalry
                }
            }
            save_scope_as = rival_country
        }
    }

    option = { # slow down, attempt to de-escalate
        name = patagonia.2.a
        default_option = yes
        scope:patagonia_state = {
            add_modifier = {
                name = patagonia_slow_down
                months = normal_modifier_time
            }
        }
        change_tension = {
            country = scope:patagonia_country
            value = -50
        }      
    }
    option = { # if they want a fight they'll get one
        name = patagonia.2.b
        change_relations = {
            country = scope:rival_country
            value = -20
        }
        change_tension = {
            country = scope:patagonia_country
            value = 25
        }
    }
}