destroy_or_downgrade_building_effect (border raiding effect) can duplicate buildings

[Loc_n_lol]

Information​

I have verifed my game files (Steam only)​

Yes

I have disabled all mods​

Yes

I am running the latest game update​

Yes

Required​

Summary​

destroy_or_downgrade_building_effect (border raiding effect) can duplicate buildings

Description​

When destroy_or_downgrade_building_effect fires, it will remove a building then add the lower level version of that building in the same province. This causes buildings to be reshuffled but otherwise works.

However, if a building other than the one being removed was under construction in the province, the reshuffling of buildings can mean that when construction finishes, the wrong building gets upgraded.

So for example if you have 4 buildings in a province with their levels : A2 B2 C2 D2
C2 is upgrading to C3
province gets targetted by a raid and D2 is destroyed, D1 gets added, buildings are now : D1 A2 B2 C2
UI shows that B2 is upgrading now, because it occupies the slot that was once C2
When construction finishes, buildings are now : D1 A2 C3 C2

The problem seems to be that remove_building forces a rearranging of the order of buildings, when there is no clear reason to do so, and the building upgrade code relies on that never happening.

Steps to reproduce​

Conclude a border raid CB while a building is under construction in the target county

Game Version​

1.9.2.1

Platform​

Windows

Additional Information​

Affected Feature​

• Gameplay

Save Game​

Other Attachments​