Enums, factions and pirates

[Hobbes__]

Hello,
This is a specific question regarding usage of the new enums.

On the faction.json, for each entry there is a field called: "IsPirate" : false

DataDrivenEnumNotes further specifies that 'The notes on IsGreatHouse, IsClan, IsMercenary, IsPirate: Not really used by HBS, but it could be useful to modders who need to select a random Merc unit.'

So my question is, if I define a number of factions as 'isPirate': true, could I then replace this:

"RequirementComparisons" : [
{
"obj" : "Target.AuriganPirates",
"op" : "Equal",
"val" : 0,
"valueConstant" : null
},
{
"obj" : "Target.CapellanPirates",
"op" : "Equal",
"val" : 0,
"valueConstant" : null
},
{
"obj" : "Target.ClusterPirates",
"op" : "Equal",
"val" : 0,
"valueConstant" : null
}

]
​

With this?

RequirementComparisons" : [
{
"obj" : "Target.IsPirate",
"op" : "Equal",
"val" : 0,
"valueConstant" : null
}
]
​

If it's possible, this would really be useful because I currently have about 12 pirate factions

 

[unclecid]

that sounds like a question for @HBS_Eck

 

[KMiSSioN]

no i've found code - only faction ids is checked.

    private SimGameState.FilteredComparisonResults GetFilteredComparisons(IEnumerable<ComparisonDef> comparisons, Func<ComparisonDef, bool> ComparisonFunc)
    {
      IEnumerable<string> strings = comparisons.Where<ComparisonDef>((Func<ComparisonDef, bool>) (c => ComparisonFunc(c))).Select<ComparisonDef, string[]>((Func<ComparisonDef, string[]>) (c => c.obj.Split('.'))).Where<string[]>((Func<string[], bool>) (s => this.IsProperLength(s))).Select<string[], string>((Func<string[], string>) (s => s[1]));
      List<string> stringList1 = new List<string>();
      List<string> stringList2 = new List<string>();
      foreach (string factionID in strings)
      {
        stringList1.Add(factionID);
        if (factionID == "IsOwner")
          stringList2.Add(FactionEnumeration.GetInvalidUnsetFactionValue().Name);
        else
          stringList2.Add(this.GetFactionValueFromString(factionID).Name);
      }
      return new SimGameState.FilteredComparisonResults((IEnumerable<string>) stringList1, (IEnumerable<string>) stringList2);
    }

 

[Hobbes__]

no i've found code - only faction ids is checked.

Thank you for the clarification - saves me the work of testing it and the frustration of not figuring out why it isn't working

 

[KMiSSioN]

I think, you can ask CWolf to add some patches fixing this behavior to mod he is working on.

 

[KMiSSioN]

I can make it too - but unfortunatly i'm not controlling any mod suitable for this - all of them working on battlefield.