Gamebreaking Decadence Revolt bugs

[Scyth33]

Not trying to be harsh but the decadence revolt event chain starting in Plus.1910 and ending in TOG.1080 is poorly coded and besides not working it is causing several CTDs.

For example the character flag decadence_unrest_event never gets removed. This means that the event won't trigger again during that character's lifetime when it's pretty clear that wasn't what it was intended as evindenced by events further down the chain. There's also a few OR conditions that should be AND.

Adding to this the decadence revolt cb_type is quite bad as you can surrender to the rebels without losing any titles as the casus belli only transfers occupied titles.

To be honest the whole event chain should be scrapped completely as it isn't entretaining and decadence penalties aren't harsh enough for vassals to revolt. Vanilla event chain does job much better, specially since the latest beta patch. In my opinion it would just be better to bring it back and tweak it accordingly to fit CK2+ if needed.

Also I've already fixed most bugs in the event chain for my own personal use but I could submit them for any of you to use or tweak if needed. Aditionally I halved decadence gain like in the latest vanilla patch as muslim dynasties were getting high decadence way too easily (80+ every 25 years at best).

Edit: Before I forget I wanted to say that I really love this mod and can't play without it. You guys do an awesome job with it.

 

[Rylock]

Not trying to be harsh but the decadence revolt event chain starting in Plus.1910 and ending in TOG.1080 is poorly coded and besides not working it is causing several CTDs.

That's a charitable way to start your comment.

For example the character flag decadence_unrest_event never gets removed. This means that the event won't trigger again during that character's lifetime when it's pretty clear that wasn't what it was intended as evindenced by events further down the chain.

Incorrect. If you'll notice this part of the trigger:

        OR = {
           NOT = { has_character_flag = decadence_unrest_event }
           had_character_flag = { flag = decadence_unrest_event days = 730 }
         }

That means that it returns true if the flag hasn't been set (so the first time the character receives such an event) or has been set for two years (all flags are tracked insofar as to how long they've been held). Once the character has had the flag for 730 days, it returns true again...and the flag's timer is reset when it is re-applied.

There's also a few OR conditions that should be AND.

You'll need to point out which ones. I'm not seeing any OR statements that aren't where they belong. But perhaps that's just my "poor coding" skills talking.

Adding to this the decadence revolt cb_type is quite bad as you can surrender to the rebels without losing any titles as the casus belli only transfers occupied titles.

Perhaps, though I'll point out that all the revolt-type CB's (other than the nationalist one, which I changed) work this way. I might go through and change them, though suggestions would be welcome as to what they should perhaps do.

To be honest the whole event chain should be scrapped completely as it isn't entretaining and decadence penalties aren't harsh enough for vassals to revolt. Vanilla event chain does job much better, specially since the latest beta patch. In my opinion it would just be better to bring it back and tweak it accordingly to fit CK2+ if needed.

You mean the vanilla revolt event that brings in a mysterious outside force to invade? No, I'm not going to restore that -- and I'd hardly call that more entertaining. Nor am I going to scrap the chain entirely on your say-so, sorry.

Also I've already fixed most bugs in the event chain for my own personal use but I could submit them for any of you to use or tweak if needed.

I'd be interested to see what you've changed, if you'd like to post it.

Aditionally I halved decadence gain like in the latest vanilla patch as muslim dynasties were getting high decadence way too easily (80+ every 25 years at best).

Fair enough. That's Kalista's department, and I think he's reviewed the decadence gains for the next version.