Problems with (and fixes for) the German Unification by Austria

[unmerged(136147)]

Hello again

There exist several problems with the unification chain. The most important and Chain-breaking one is the federal fortresses event:

The trigger for SFG to hand over the federal fortresses is this:

trigger = {
		flag = { name = AUS_empire value = 1 }
		OR = {
			owned = { province = 787 }
			owned = { province = 865 }
			owned = { province = 804 }
			owned = { province = 786 }
		}
		satellite = { country = SGF country = AUS }
	}

While the trigger for the Austrian receiving event is this:

	trigger = {
		flag = { name = flg_fuerstentag value = 1 }
		owned = { province = 787 }
		owned = { province = 865 }
		owned = { province = 804 }
		owned = { province = 786 }
	}

This makes the SFG event fire as soon as it has one of the Provinces thereby never giving the other Provinces, which it might get a bit later, to Austria and never triggering the Austrian event. The chain gets broken.
One simple fix would be to delete the OR condition in the SFG event.
However from the event description of the Austrian event: "the transfer of the federal fortresses is finally complete" and the fact than an OR trigger was used to begin with I believe it was originally intended for the Provinces to be transferred one by one, delayed by the offset and the slow annexation of German minors.
In this case it would be better to add a

persistent = yes

to the head of the SFG event.
The persistent function has a problem of it's own tough, in that it requires either a reload or the event needs to be triggered by a trigger command again for the function to work.
So the solution is to put

command = { type = trigger which = 260001 }

into the command section of the SFG Federal Fortresses event. This way a self repeating loop is created until all the provinces have been seceded to Austria.

The finished SFG event would like this:

event = {
	id = 260001
	random = no
	persistent = yes
	country = SGF

	trigger = {
		flag = { name = AUS_empire value = 1 }
		AND = {
			owned = { province = 787 }
			owned = { province = 865 }
			owned = { province = 804 }
			owned = { province = 786 }
		}
		satellite = { country = SGF country = AUS }
	}

	name = "The Federal Fortresses"
	desc = "The Habsburgs have demanded we hand sovereignty over the Federal Fortresses to Austria"
	style = 0

	date = { day = 3 month = july year = 1866 }
	offset = 5
	deathdate = { day = 30 month = december year = 1870 }

	action_a = {
		name = "ACCEPT_END"
		command = { type = secedeprovince which = AUS value = 787 } # Mainz
		command = { type = secedeprovince which = AUS value = 865 } # Rastatt
		command = { type = secedeprovince which = AUS value = 804 } # Ulm
		command = { type = secedeprovince which = AUS value = 786 } # Landau
		command = { type = trigger which = 260001 }
	}
}

Another problem exist with German minors Prussia might annex during the 7 weeks war.
This isn't very imported when you choose the Full reform (Grossdeutschland) option as Austria since Prussia secedes the provinces later to the SFG anyway.
However, it can lead to the cosmetic problem of Austria not receiving Frankfurt.
And when you choose the moderate reforms it can probably led to the SFG or NFG not getting what they should.
There are already "release the German Minors" events for Prussia, however these trigger only after Prussia has been defeated in the early German Leadership war.
All that needs to be done is to add the trigger commands for these events also to the "Fall Of Prussia" event in the German nations folder that fires after Austrias victory in the 7 weeks war. It can't be added directly to the Prussian surrender event since this has multiple options:

event = {
	id = 4630
	random = no
	country = PRU

	trigger = {
		flag = { name = flg_Austria_contests value = 1 } #Set by 4626a
		OR = {
			won_war = { country = AUS country = PRU }
			
			event = 247148 #AUS wins 7 Weeks War
		}
	}

	name = "Austria Has Defeated Prussia"
	desc = "EVT_4630_DESC"
	style = 0

	date = { day = 28 month = december year = 1846 }
	offset = 30
	deathdate = { day = 30 month = december year = 1935 }

	action_a = {
		name = "ACTIONNAME4630A"
		command = { type = prestige value = -100 }
		command = { type = neutrality }
		command = { type = sleepevent which = 7705 } #Spain hohenzollern crown - not offered if PRU humilitated
		command = { type = setflag which = flg_AUSHumilPRU }
		# Liberation of the german minors
		command = { type = trigger which = 247230 }
		command = { type = trigger which = 247231 }
		command = { type = trigger which = 247232 }
		command = { type = trigger which = 247234 }
		command = { type = trigger which = 247235 }
		command = { type = trigger which = 247236 }
		command = { type = trigger which = 247238 }
		command = { type = trigger which = 247239 }
		command = { type = trigger which = 247240 }
		command = { type = trigger which = 247242 }
		command = { type = trigger which = 247243 }
		command = { type = trigger which = 247244 }
		command = { type = trigger which = 247246 }
		command = { type = trigger which = 247248 }
		command = { type = trigger which = 247250 }
		command = { type = trigger which = 247251 }
		command = { type = trigger which = 247252 }
		command = { type = trigger which = 247253 }
		command = { type = trigger which = 247254 }
		command = { type = trigger which = 247256 }
		command = { type = trigger which = 247258 }
		command = { type = trigger which = 247259 }
		command = { type = trigger which = 247260 }
		command = { type = trigger which = 247261 }
		command = { type = trigger which = 247262 }
		command = { type = trigger which = 247263 }
		command = { type = trigger which = 247264 }
		command = { type = trigger which = 247265 }
		command = { type = trigger which = 247266 }
		command = { type = trigger which = 247267 }
		command = { type = trigger which = 247268 }
		command = { type = trigger which = 247270 }
		command = { type = trigger which = 247272 }
		command = { type = trigger which = 247274 }
	}
}

The trigger of this event is set up in a way that it also triggers if Austria loses the 7 weeks war but wins some other war later on. I'm not sure if this is intended or not but IMO it should be changed to only trigger after Prussias defeat in the 7 weeks war.

Last and indeed least there is a tiny cosmetic probleme with the "Partial Unification Of Germany" event for the SFG. (in the SFG.txt in the German nations folderm not the main one)
This is meant for another unification event chain and has nothing to do with the Austrian unification.
But since the only trigger condition is that Germany exists it will also trigger once Austria has turned into Germany. Since Austria doesn't exist anymore in this case it doesn't cause in-game damage but the fact that Grossdeutschland is exactly the opposite of a Partial Unification makes this event very annoying to fire.
A fix would simply be to change the trigger so that it doesn't fire in case of Austrian unification:

event = { 
	id = 3200
	random = no
	country = SGF
	
	trigger = { 
	exists = GER 
	NOT = { 
		flag = { name = habger value = 1 } 
		}
	}	

	name = "EVT111251N"
	desc = "EVT111251D"
	style = 0
	
	date = { day = 1 month = january year = 1849 }
	offset = 30
	deathdate = { day = 30 month = december year = 1935 }
	
	action_a = {
		name = "ACTIONNAME3200A"
		command = { type = trigger which = 111251 }
	}
	action_b = {
		name = "ACTIONNAME3200B"
		command = { type = prestige value = -200 }
	}
}

So, that would fix all the problems I encountered

EDIT: ARGH! Wrong Forum. Please delte this Thread