Duplicate Requirement for Achievements Enabled is inconsistent between Lobby and In Game

[Elaugaufein]

Information​

I have verifed my game files (Steam only)​

Yes

I have disabled all mods​

Yes

I am running the latest game update​

Yes

Required​

Summary​

Requirement for Achievements Enabled is inconsistent between Lobby and In Game

Description​

Under certain conditions the Lobby will say Achievements are Enabled but they will be immediately disabled when the game starts.

One cause of this is that the In Game Achievement check seems to be performing a Checkum verification on gui/window_ruler_designer.gui while the Lobby check does not.

This inconsistency is clearly undesirable and these checks should be made the same.

However I'd like to suggest removing the Checksum here all together because I don't think it's accomplishing it's goal (which I think is to avoid working around the 400 Point Character Limit) , however because of how defines work, a mod can override the Achievement Character point limit in a file in defines, that is loaded after 00_defines.txt (eg 01_defines.txt), that isn't checksummed and this doesn't prevent achievements, so checksumming the ruler_designer doesn't achieve anything. In so far as I can tell, you also can't do anything in the ruler designer that couldn't be achieved by mods using decisions/effects.

Steps to reproduce​

1) Have a modded gui/window_ruler_designer.gui file loaded
2) setup achievements to be enabled in the Lobby
3) then start the game.
4) Check and verify that achievements are now disabled.

Game Version​

1.9.0.4

Platform​

Windows

Additional Information​

Affected Feature​

• Achievements
• Modding

Save Game​

Other Attachments​

 

[Elaugaufein]

This has been fixed as of 1.9.1

 

[Polished knight]

Happy to see that its fixed, thanks for the confirmation!