The Validator - Find errors quickly and with minimal pain!

[Jamie550]

see, however THIS is only possible as a RHS scope, unlike ROOT, FROM etc.

You can always request it in the hard stuff bucket at some later point.

The 'family' trigger should no longer accept title scopes, which I think it currently does.

Have changed it so that the RHS can no longer point to ROOT/etc pointing to a title

As for duplicate RHS triggers, they can be used to restrict numerical values to a range, for example 'wealth > 100; wealth <= 500'. Obviously the example you provided is rather silly and was never meant as anything more than a report.

Ok so I definitely think you reported some comparison operator issue where we only reported RHS duplicates but don't feel like looking for it so maybe it doesn't exist.

To be clear, for any comparison operator, we can always require that the RHS be unique?

It's not a historical character, but a randomly generated baron at game start. If that's intended, nothing needs to be done.

I don't think Validator can predict which characters get randomly generated. So this is actually useful to have in a mod that you target randomly generated characters in the game script?

Found in 03_scripted_effects_sainthood.txt, lines 2-5 (save_persistent_event_target_as).

If you use save_persistent_event_target_as, would you then need to use "persistent_event_targetrovince_saint" instead of "event_targetrovince_saint"?

Found in HF_realm_decisions.txt, lines 644-647 (save_persistent_event_target).

Same question: Saving with save_persistent_event_target but not accessing with "persistent_event_target:XXX"

Found in 01_scripted_effects_duels.txt, lines 2101 and 2150.

This is saying nothing is using the event target that was saved. Where is the event target being used?

Found in HFP_random_flavor_events.txt, line 2146.

We see an error at the callsite which explains the false positive.

--- Error 230 of 601 ---
At <mod>\events\HFP_random_flavor_events.txt [character_event\immediate\FROM] (Line 2146, column 3):
No direct match found for FROM (is the casing correct?). However, other possible matches in scope CharCommand were found.
Left: [ThisChar] Right: [CharCommand] cannot be correct because of left: FROM points to <null>.
However, a Char was expected.
This scope was inferred to have scope Char, but the call at <mod>\common\on_actions\15_holy_fury.txt [on_artifact_inheritance\random_events\5] (Line 653, column 3)(OnAction on_artifact_inheritance) is of scope Artifact.
Left: [ThisProv] Right: [ProvCommand] cannot be correct because of left: FROM points to <null>.
However, a Prov was expected.
This scope was inferred to have scope Char, but the call at <mod>\common\on_actions\15_holy_fury.txt [on_artifact_inheritance\random_events\5] (Line 653, column 3)(OnAction on_artifact_inheritance) is of scope Artifact.
Left: [ThisTitle] Right: [TitleCommand] cannot be correct because of left: FROM points to <null>.

This looks like an issue with repeat_event most likely. Or at least we should wait for repeat_event to be solved before reexamining it.

Found in jd_chinese_invasion_events.txt, line 2710.

Possibly also repeat_event issue.

Found in mnm_devil_worshipers_events.txt, line 7183.

--- Error 243 of 601 ---
At <mod>\events\mnm_devil_worshipers_events.txt [character_event\immediate\FROM\save_event_target_as] (Line 7110, column 12):
This event target event_target:dw_desecration_target was inferred to have type Char at <mod>\events\mnm_devil_worshipers_events.txt [character_event\immediate\random_quest_target\save_event_target_as] (Line 7146, column 4) but here has type Title

I assume this error indicates problems which are preventing desecration_holder from working. You can see whether the error is real or a false positive or what.

Found in LT_wonder_maintenance_effects.txt, line 142.

Is log statements the only strings we have to check for these (besides localization ofc), and do they behave just like localization strings? Anyways you can put this on the hard things list if you care enough.

Any not replied to also look like the save_persistent_event_target but not accessing with persistent_event_target: issue

Added in patch 1.07, but never used in vanilla. Supports 2.8-style numerical operators. Haven't figured out what this one actually does. Only seems to work in character scope.

We should probably wait until it turns out to be useful before adding it.

Here's a list, for convenience:

Was convenient to have the list.

Hard stuff: repeat_event

The about-to-be-posted version will not have this.