CK II - [3.0.1 CDYZ] Can't declare Invasion due to likely integer overflow at ~2M nomad population

[Arrnea]

One line summary of your issue
[3.0.1 CDYZ] Can't declare Invasion due to likely integer overflow at ~2M nomad population

Game Version
3.0.1 CDYZ

What expansions do you have installed?
All of the above

Do you have mods enabled?
Yes, but none that change the checksum.

Please explain your issue is in as much detail as possible.
When attempting to declare an Invasion CB war with a nomad horde having more than about 2 million total population, the game doesn't seem to think that you are at over 75% of your maximum population even when you are, and hence won't let you declare the war. I would guess that this is because of an integer overflow somewhere.

Steps to reproduce the issue.
Blob really hard as a nomad horde (eg. Mongols, Khazaria) until you have >2M nomad population and attempt to declare an Invasion war on someone.

Upload Attachment

 

[Arrnea]

As an additional note, I would guess that this bug is caused specifically by the total nomad population exceeding 2,147,483.648 (2^32 / 2000).
This is unfortunate, because your nomad population will almost certainly reach this before total conquest, no matter who you are playing as, making further conquest impractical.

 

[clovenhoof]

I'm not sure why you have 2000 as a denominator. Perhaps it's a known thing--well, a thing known by others. But an alternative case is that it is somehow processed as a 21-bit number which would overflow at 2,097,152.

 

[Arrnea]

I'm not sure why you have 2000 as a denominator. Perhaps it's a known thing--well, a thing known by others. But an alternative case is that it is somehow processed as a 21-bit number which would overflow at 2,097,152.

I was thinking 2,000 because it's probably processed as a signed 32-bit integer, but storing the first three decimal places (for whatever reason) as part of the integer.

 

[Arrnea]

This is still an issue - I hope it's been noted already (and that's why I'm not getting any dev response).

 

[Arrnea]

Aaaand this is still broken (effectively preventing further play in this game), without even a single dev acknowledgement (for almost two months).

What gives, Paradox?

 

[Arrnea]

Still broken. Can this please get looked at?
It's stopping me having any interest in playing as a nomad (since the entire point of nomad play beyond a certain point is to burn down the entire world).

 

[MonzUn]

Sorry for not acknowledging this earlier.
It might be because the STR takes some time to do and that there wasn't any save file.

I've made a potential fix for this issue, if it works and has no side effects it should be included in the next patch (after Great Works).

 

[Arrnea]

Sorry for not acknowledging this earlier.
It might be because the STR takes some time to do and that there wasn't any save file.

I've made a potential fix for this issue, if it works and has no side effects it should be included in the next patch (after Great Works).

Awesome. A million internet points!

[begins plotting to burn even more of the world as a rampaging nomad horde]

 

[ShinigamiKenji]

Had posted the same bug a while ago (BTW I think you also commented my thread). Nice to see it's getting a solution!

 

[clovenhoof]

I was thinking 2,000 because it's probably processed as a signed 32-bit integer, but storing the first three decimal places (for whatever reason) as part of the integer.

This is probably right. I see a failed crusade in the planning stages right now, and the attackers have no one on their side. The defenders, including me, have an enormous army. The total strength reported is 2 147 483 percent (of the attackers' strength), which is 2^31/1000, after truncating the fraction.