Why won't my on_actions event fire? (Solved)

[Sriseru]

I'm working on a mod, but I've encountered an issue that I cannot resolve on my own.
So I've added a culture, a trait, an event, and an on_actions call to fire said event, but the event is never fired. The event works perfectly fine if I call it via the console, but for some reason the on_actions won't fire it.

The event code is in a file named "sergal_on_action_events.txt" and it looks like this:

namespace = sergalevent

#Gives Sergals the Sergal trait
character_event = {
    id = sergalevent.1
    hide_window = yes

    is_triggered_only = yes

    trigger = {
        culture = oldsergal
        NOT = { trait = sergal_trait }
    }
    immediate = {
        add_trait = sergal_trait
    }
}

And the on_actions file is named "SERGAL_on_actions.txt" and its code looks like this:

#character
on_startup = {
    events = {
        sergalevent.1
    }
}

#character
on_yearly_pulse = {
    events = {
        sergalevent.1
    }
}

Could someone please tell me what I've done wrong?

Edit: on_yearly_pulse correctly fires the event, so the issue seems to be with on_startup. Has anyone else encountered this issue?

 

[Whizzer]

And the on_actions file is named "SERGAL_on_actions" and its code looks like this:
Could someone please tell me what I've done wrong?

The contents of your files look good to me. If this file does indeed not have a file extension, that would be why.

 

[Sriseru]

The contents of your files look good to me. If this file does indeed not have a file extension, that would be why.

It does have a file extension, I just forgot to add it to my post. I just edited it in.

 

[TwiddleFactor]

on_startup is a slightly dangerous
on_action event, because it will fire for all characters every single in the game every time you load the game. This could potentially increase your game load time a lot for an old save.

That being said, have you tested out when it works and when it doesn't work? Does the on_startup action work when loading a save but not when starting a new game? Checking the wiki, I noticed the following bug note on the on_startup description, "BUG (as of version 3.2.1): at the start of the new game, it does not fire for courtiers that are not defined in the history files." It also says that it doesn't work for ruler designed characters, but I am not sure if this is true, because I use this on_action for the player character in a mod of mine and I'm pretty sure it fires just fine even when the player character is made with the ruler designer.

 

[Sriseru]

on_startup is a slightly dangerous
on_action event, because it will fire for all characters every single in the game every time you load the game. This could potentially increase your game load time a lot for an old save.

That being said, have you tested out when it works and when it doesn't work? Does the on_startup action work when loading a save but not when starting a new game? Checking the wiki, I noticed the following bug note on the on_startup description, "BUG (as of version 3.2.1): at the start of the new game, it does not fire for courtiers that are not defined in the history files." It also says that it doesn't work for ruler designed characters, but I am not sure if this is true, because I use this on_action for the player character in a mod of mine and I'm pretty sure it fires just fine even when the player character is made with the ruler designer.

My character was made with the ruler designer (because the event uses a custom culture as a trigger), so that's probably why. Thanks for pointing it out. I've been checking the wiki extensively while working on my mod, but I completely missed the segment on on_actions.

 

[TwiddleFactor]

My character was made with the ruler designer (because the event uses a custom culture as a trigger), so that's probably why. Thanks for pointing it out. I've been checking the wiki extensively while working on my mod, but I completely missed the segment on on_actions.

From what I remember when I was playing around with on_startup, it is a very special on action and seems to run before the game is actually fully initialized. In the case of a ruler designed character, I believe this means that the event actually runs on the character that should have the title your character is taking over. You could test this by adding a trait with the event and seeing if it is added to the original character or not, who should be a courtier in your court.

The easiest solution might be to have the on_startup event only run on the player character and have it call another event that is on a 1 day delay which checks all game characters and adds the trait if they have the right culture.

Since only the player can make a ruler designed character though, why not just add the trait to the ruler designer options?

 

[Sriseru]

From what I remember when I was playing around with on_startup, it is a very special on action and seems to run before the game is actually fully initialized. In the case of a ruler designed character, I believe this means that the event actually runs on the character that should have the title your character is taking over. You could test this by adding a trait with the event and seeing if it is added to the original character or not, who should be a courtier in your court.

The easiest solution might be to have the on_startup event only run on the player character and have it call another event that is on a 1 day delay which checks all game characters and adds the trait if they have the right culture.

Since only the player can make a ruler designed character though, why not just add the trait to the ruler designer options?

I managed to find a good workaround by using "on_chronicle_start" instead. I appreciate all the help though. <3