1.9.2.1 : The fabricate hook scheme always applies the penalties for being discovered, even if the scheme is not actually discovered

[Question]

Information​

I have verifed my game files (Steam only)​

Yes

I have disabled all mods​

Yes

I am running the latest game update​

Yes

Required​

Summary​

1.9.2.1 : The fabricate hook scheme always applies the penalties for being discovered, even if the scheme is not actually discovered

Description​

WeeLittleSpoon's post here explains it in detail : https://forum.paradoxplaza.com/foru...-fabricating-hooks-work.1593231/post-29049411

Basically, the scripted effect fabricate_hook_success_effect incorrectly applies the effect fabricate_hook_discovery_effect = yes even if the scheme is not actually discovered. This means that even if the scheme is not discovered, it will ALWAYS apply the massive -40 opinion penalty for both the target and their liege.

Steps to reproduce​

To fix, remove fabricate_hook_discovery_effect = yes from the ELSE portion.

Game Version​

1.9.2.1

Platform​

Windows

Additional Information​

Affected Feature​

• Events

Save Game​

Other Attachments​

 

[Question]

I think theres another error here. The success effect seems to have been badly copy pasted.

This should fix it :

#Used in event options
fabricate_hook_success_effect = {
    fabricate_hook_assign_appropriate_type_effect = {
        TYPE = $TYPE$ # Sets the correct hook type to give
    }
    if = {
        limit = { exists = scope:target.court_owner }
        scope:target.court_owner = { save_scope_as = court_owner }
    }

    if = {
        limit = {
            exists = scope:scheme_discovered
        }
        custom_tooltip = fabricate_hook_i_may_not_fabricate_again
        #scope:target = {
            #add_opinion = {
                #target = scope:owner
                #modifier = fabricated_hook_against_court_opinion
                #years = 5
            #}
        #}
        fabricate_hook_discovery_effect = yes
    }
    

    if = {
        limit = { exists = scope:scheme }
        scope:scheme = {
            end_scheme = yes
        }
    }
}

By default it check is the target is the court owner and adds a fabricated hook opinion, but this is unnecessary because the discovery effect already does that. So in the above code i just made it run the discovery effect if the scheme is discovered, else it does nothing.