BATTLETECH - Firepower miscalculation

[Thandor]

One line summary of your issue
Firepower miscalculation

What platform are you running the game on?

GoG

What operating system do you use?
Windows 10
Which version of the game are you running?
1.9.1-686R
What DLC do you have installed?
Flashpoint,
Urban Warfare,
Heavy Metal

Please explain your issue is in as much detail as possible.
In the 'Mech lab, the tooltip for the performance bar "FIREPOWER" shows incorrect numbers for "MAX STABILITY DMG" when your 'Mech has multiple shot weapons mounted, (includes all LBX, UAC, Snub-PPC, LRM, and SRM weapons, regardless of variant).
It seems the tooltip currently only includes stability damage from the first shot/missile of a volley and ignores the rest in the calculation.
I think this error was also present in the previous patch as I recall seeing a post about it recently.

A second thing is certain new 'Mechs special equipment:
Warhammer: Optimized Capacitors (+20% Energy Dmg)
Annihilator: BSC System (+20% Ballistic Dmg. +40 Max Stability)
Their respective bonus damage is not added to the "MAX DMG" of the "FIREPOWER" tooltip either.
Have you tried verifying your files?
Yes

Steps to reproduce the issue
Look up the "FIREPOWER" tooltip in the 'Mech lab for any 'Mech carrying multiple shot weapons (SRM, LRM etc.), and look up any Warhammer or Annihilator for the second point.

Attach DxDiag (PC), System Info log (Mac), or run sudo lshw -html > specs.html and uploaded specs.html (Linux)

Attach Output Log
Windows: \Users\YourUserName\AppData\LocalLow\Harebrained Schemes\BATTLETECH\output_log.txt
Mac OS: Users >{name} > Library > Logs > Unity > Player.log
Linux: ~/.config/unity3d/Harebrained Schemes/BATTLETECH/Player.log

If the game crashed, please attach the crash file with the time stamp closest to the crash.
Windows: [Steam library folder]\steamapps\common\BATTLETECH\DumpBox
For v.17 and beyond try here: C:\Users\[YourUserName]\AppData\LocalLow\Harebrained Schemes\BATTLETECH
OSX: Macintosh HD > Users > [username] > Library > Application Support > Steam > steamapps > common > BattleTech > DumpBox
Linux: [Steam library folder]/steamapps/common/BATTLETECH/DumpBox

If a save game was loaded at the start of the game session, upload it. Please make sure to upload the save game with the timestamp closest to when you loaded it.
Windows:
Steam: [Steam installation folder]\userdata[SteamID]\637090\remote\C0\SGS1
GOG: 'C:\Users\USER_ID\AppData\Local\GOG.com\Galaxy\Applications\50593543263669699\Storage\Shared\Files\C#\SGS#'
Vanilla:'C:\Users\USER_ID\AppData\LocalLow\Harebrained Schemes\BattleTech\C#\SGS#'
OSX:
Steam: Macintosh HD > Users > [username] > Library > Application Support > Steam > userdata > [SteamID] > 637090 > remote > C#> SGS#
GOG: Macintosh HD > Users > [username] > Library > Application Support > GOG.com > Galaxy > Applications > 50593543263669699 > Storage > Shared > Files > C# > SGS#
Vanilla: Macintosh HD > Users > [username]> Library > Application Support > unity.Harebrained Schemes.BattleTech > C# > SGG#
Linux:
Steam: /home/.steam/steam/userdata/[steamID]/637090/remote/C#/SGS#
GOG: /home/[username]/.config/unity3d/Harebrained Schemes/BATTLETECH/remote/C#/SGS#/
Vanilla: /home/[username]/.config/unity3d/Harebrained Schemes/BATTLETECH/remote/C#/SGS#/

Attach screenshot / video

 

[Mad2342]

StatTooltipData.SetFirepowerData(), have a look at damage vs. instability:

num += ((weaponDef.ShotsWhenFired > 0) ? (weaponDef.Damage * (float)weaponDef.ShotsWhenFired) : weaponDef.Damage);
num2 += ((weaponDef.ShotsWhenFired > 0) ? weaponDef.Instability : (weaponDef.Instability * (float)weaponDef.ShotsWhenFired));

For instability the result is the wrong way around...
A quickwin for the devs...

 

[Mad2342]

Added this to my bugfix mod, google "github battletech littlethings" if interested

 

[Thandor]

Nice! and now the devs even have an example of the full fix as well.
Could not be easier
Well done.