Bugfixes for rare, but annoying bugs

[Phi]

After improving my solution to remove BAR- and REB-states and abusing the title hack again to give cores to core-free countries like new regions (i.e. Greek Armenia), I decided to start a bugfix-collection for rare, but annoying bugs.

Fixed rare, but annoying bugs:
- no more REB- or BAR-states
- no more countries without a core (hence without the ability to build normal units)

As you can see, I have a liberal definition of bug.

Simply add the following at the end of common/titles.txt in your preferred mod:

#######################
### Phi - bug fixes ###
#######################

# Remove REB- and BAR-states
# Case one: There are neighbours
title_remove_bad_states = { 
  allow = {
    is_ruler = yes
  }

  gain_trigger = {
    country = {
      any_neighbor_country = {
        OR = {
          tag="REB"
          tag="BAR"
        }
      }
    }
  }
  
  gain_effect = {
    country = {
      any_neighbor_country = {
        limit = {
          OR = {
            tag="REB"
            tag="BAR"
          }
        }
        random_owned = {
          secede_province = THIS
        }
      }
    }
  }
  
  lose_trigger = {
    title_remove_bad_states = 1
  }
}

# Case two: There are no neighbours
title_remove_bad_states2 = {  
  allow = {
    is_ruler = yes
  }

  gain_trigger = {
    country = {
      any_country = {
        OR = {
          tag="REB"
          tag="BAR"
        }
        # There is no neighboring country
        NOT = {
          any_country = {
            any_neighbor_country = {
              OR = {
                tag="REB"
                tag="BAR"
              }
            }
          }
        }
      }
    }
  }
  
  gain_effect = {
    country = {
      any_country = {
        limit = {
          OR = {
            tag="REB"
            tag="BAR"
          }
          # There is no neighboring country
          NOT = {
            any_country = {
              any_neighbor_country = {
                OR = {
                  tag="REB"
                  tag="BAR"
                }
              }
            }
          }
        }
        random_owned = {
          secede_province = THIS
        }
      }
    }
  }
  
  lose_trigger = {
    title_remove_bad_states2 = 1
  }
}

# Give states without a core (i.e. regions)
# a core on its capital
# They can't build units without one.
title_we_need_a_core = {
  allow = {
    is_ruler = yes
    NOT = {
      country = {
        OR = {
          tag = "REB"
          tag = "BAR"
        }
      }
    }   
  }

  gain_trigger = {
    country = {
      any_province = {
        NOT = { is_core = yes }
      }
    }
  }
  
  gain_effect = {
    country = {
      capital_scope = {
        add_core = THIS
      }
    }
  }
  
  lose_trigger = {
    title_we_need_a_core = 1
  }
}