civic_distinguished_admiralty not giving 2 leaders skills to hired commanders at the start of the game

[Alan Kraskow]

Description
As the title says, the civic doesn't give 2 leader skills to already hired commander and ruler commander. But it does give them to commanders available for hire.

Game Version
4.0.21

What version do you use?
Steam

What expansions do you have installed?


Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
Seems like the modifier in the civic script commander_initial_skill = 2 doesn't work on already hired commander and ruler after the start of the game. This bug is present in game since patch 4.0.15 or maybe even earlier.
What's interesting both commanders (including ruler) start at level 3 but without trait picks.
Steps to reproduce the issue.


Upload Attachment
File(s) attached

 

[Akashi Zetsugou]

First of all, you wasn't rude at all, and I really appreciate your help!

"Distinguished Admiralty" civic shouldn't give additional non-selectable traits, only +2 starting levels.

Spoiler: Wiki

View attachment 1337337

I don't know how it works in 4.0.14 or 4.0.22, I use only 4.0.21 now. The event "leader.110", which I suggested to edit, gives to leaders additional traits from civics and origins, and there is nothing about "Distinguished Admiralty" civic.

In all my tests on 4.0.21 with this fix only (you have discarded previous changes of the "game_start.txt", have you?) I got as many trait choices for every leader, as its level minus one. And I think, that was intended.

Thank goodness, I dont want to be rude since you are really working on something I desperately need to enjoy the game. I completely agree with you that it should be five skills, but I am mostly saying that as of 4.0.10 it gives an additional skill point for basic skills when using distinguished admiralty to the under one rule ruler type commander and starting commander, it definitely seems weird but thats how it has been as of 4.0.10 (oldest version I have tried yet) and as of 4.0.14 before it was broken in all the following versions. That and your fix, at least in 4.0.22 gives an additional option for a veteran trait and one less basic trait even by the progression chart to the under one rule commander ruler (on top of lacking that additional basic trait that seemingly comes from nowhere). Here I just tested 4.0.10, I will do 4.0.14, since it gets broken after, and do it for 4.0.21 so you can see what I mean in your version. If you look, the ruler has three basic skills and the starting commander has 4 (1 it started with and 3 I chose).

 

[X-Proxy]

Do you mind explaining what game start changes I would have?

Honestly? I have no idea) My gameplay now is searching for bugs that I'm able to fix by myself. I don't use 4.0.22 beta because it can be changed at any time.

 

[Akashi Zetsugou]

Honestly? I have no idea) My gameplay now is searching for bugs that I'm able to fix by myself. I don't use 4.0.22 beta because it can be changed at any time.

Alright then I will go ahead and do it in 4.0.21 just to check if it is also having the same issue

 

[X-Proxy]

The code does what it was told to do, not what I thought it should do) I hope on 4.0.21 with my fix you will get exactly the same, what I have: one starting random common trait for non-ruler leader + its level minus one additional trait choices.

 

[Akashi Zetsugou]

Honestly? I have no idea) My gameplay now is searching for bugs that I'm able to fix by myself. I don't use 4.0.22 beta because it can be changed at any time.

For 4.0.14, showing how it gives 1 choice and says 5 more (total 6 traits (3 basic traits, one class, and 2 veteran traits choices)) for the ruler, and 1 choice and says 2 more (total 3 basic traits choices) for the starting commander going for 4.0.21 right now

 

[Akashi Zetsugou]

The code does what it was told to do, not what I thought it should do) I hope on 4.0.21 with my fix you will get exactly the same, what I have: one starting random common trait for non-ruler leader + its level minus one additional trait choices.

4.0.21 still doing this, I never added the game start code, I added the one you said was better, I finally understand what you were saying. Sadly it still has the same issue, it goes into class, one basic skill, and jumps into 3 veteran traits, so it isnt even following the right progression (missing at least 1 more basic skill (1 phantom basic skill) and has 1 more veteran trait than it should have), though you are definitely in the right track, the startinf commander does get the 2 it should by the progression, though as my other pictures show, it should be 3 but I have no idea were the additional basic trait point is coming from for both.

 

[X-Proxy]

Do we agree about the amount of given trait choices? As I said before,my fix doesn't affect suggested traits, it only gives you such choices.

 

[Akashi Zetsugou]

Do we agree about the amount of given trait choices? As I said before,my fix doesn't affect suggested traits, it only gives you such choices.

Ahhhhh yeah my bad, I see what you mean, you just gave the choices, which it does, you are not worried that they should be the technically right ones. my bad. then yeah I get it now, take care!

 

[X-Proxy]

I don't think that the devs gave modders a possibility to change suggested traits directly, it seems hardcoded. But I'm glad that we finally understood each other)

 

[X-Proxy]

1. I made a little mistake for that minor fix for the Technocracy civic + the Broken Shackles origin. There should be "leader = { is_councilor = no }", not just "is_councilor = no". It's funny, that for this situation it worked anyway)

Please check the updated post:

civic_distinguished_admiralty not giving 2 leaders skills to hired commanders at the start of the game

Description As the title says, the civic doesn't give 2 leader skills to already hired commander and ruler commander. But it does give them to commanders available for hire. Game Version 4.0.21 What version do you use? Steam What expansions do...

forum.paradoxplaza.com

2. If you don't want any common traits for you luminary leader, I found the solution. In the file "C:\Program Files (x86)\Steam\steamapps\common\Stellaris\events\origin_events_paragon.txt" for the event "paragon.5000" you need to change the line "add_skill_without_trait_selection = 3" to this bunch of code:

Spoiler: Bunch of code

            #add_skill_without_trait_selection = 3
            set_skill = 3
            add_skill_without_trait_selection = 1
            if = {
                limit = {
                    num_traits = 2
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_military_knowledge
                    }
                    add_trait = {
                        trait = leader_trait_legendary_military_knowledge_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_military_knowledge_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_foe_hammer
                    }
                    add_trait = {
                        trait = leader_trait_legendary_foe_hammer_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_foe_hammer_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_great_teacher
                    }
                    add_trait = {
                        trait = leader_trait_legendary_great_teacher_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_great_teacher_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_pious_ascet
                    }
                    add_trait = {
                        trait = leader_trait_legendary_pious_ascet_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_pious_ascet_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_commanding_presence
                    }
                    add_trait = {
                        trait = leader_trait_legendary_commanding_presence_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_commanding_presence_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_high_king
                    }
                    add_trait = {
                        trait = leader_trait_legendary_high_king_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_high_king_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_gunboat_diplomacy
                    }
                    add_trait = {
                        trait = leader_trait_legendary_gunboat_diplomacy_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_gunboat_diplomacy_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_scientific_diplomacy
                    }
                    add_trait = {
                        trait = leader_trait_legendary_scientific_diplomacy_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_scientific_diplomacy_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_autarky
                    }
                    add_trait = {
                        trait = leader_trait_legendary_autarky_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_autarky_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_natural_ruler
                    }
                    add_trait = {
                        trait = leader_trait_legendary_natural_ruler_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_natural_ruler_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_industry_titan
                    }
                    add_trait = {
                        trait = leader_trait_legendary_industry_titan_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_industry_titan_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_great_inventor
                    }
                    add_trait = {
                        trait = leader_trait_legendary_great_inventor_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_great_inventor_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_genetic_purist
                    }
                    add_trait = {
                        trait = leader_trait_legendary_genetic_purist_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_genetic_purist_3
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_evervigilant
                    }
                    add_trait = {
                        trait = leader_trait_legendary_evervigilant_2
                        show_message = no
                    }
                    add_trait = {
                        trait = leader_trait_legendary_evervigilant_3
                        show_message = no
                    }
                }
            }
            else_if = {
                limit = {
                    num_traits = 4
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_military_knowledge
                    }
                    add_trait = {
                        trait = leader_trait_legendary_military_knowledge_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_foe_hammer
                    }
                    add_trait = {
                        trait = leader_trait_legendary_foe_hammer_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_great_teacher
                    }
                    add_trait = {
                        trait = leader_trait_legendary_great_teacher_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_pious_ascet
                    }
                    add_trait = {
                        trait = leader_trait_legendary_pious_ascet_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_commanding_presence
                    }
                    add_trait = {
                        trait = leader_trait_legendary_commanding_presence_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_high_king
                    }
                    add_trait = {
                        trait = leader_trait_legendary_high_king_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_gunboat_diplomacy
                    }
                    add_trait = {
                        trait = leader_trait_legendary_gunboat_diplomacy_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_scientific_diplomacy
                    }
                    add_trait = {
                        trait = leader_trait_legendary_scientific_diplomacy_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_autarky
                    }
                    add_trait = {
                        trait = leader_trait_legendary_autarky_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_natural_ruler
                    }
                    add_trait = {
                        trait = leader_trait_legendary_natural_ruler_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_industry_titan
                    }
                    add_trait = {
                        trait = leader_trait_legendary_industry_titan_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_great_inventor
                    }
                    add_trait = {
                        trait = leader_trait_legendary_great_inventor_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_genetic_purist
                    }
                    add_trait = {
                        trait = leader_trait_legendary_genetic_purist_2
                        show_message = no
                    }
                }
                if = {
                    limit = {
                        has_trait = leader_trait_legendary_evervigilant
                    }
                    add_trait = {
                        trait = leader_trait_legendary_evervigilant_2
                        show_message = no
                    }
                }
            }

It's not so neat like the previous one, but it works! No more common traits, only upgrading for those unique, which were chosen by you! I also attached my version of this file for 4.0.21.