CK II - [3.0.1] Secret cult induction events miscoded

[CyberSpyder]

One line summary of your issue
[3.0.1] Secret cult induction events miscoded

Game Version
3.0.1 CDYZ

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
I found two issues in the secret faith events from monks and mystics.

First, put concisely, the chances of an AI character accepting induction into a secret faith are substantially lower than they should be due to a wrong-scope issue in the event governing it. This is not at all obvious in play, since one normally doesn't know what the chance of success should be, which is no doubt why the bug has survived so long (since the release of MNM, I guess); I only discovered it when code-diving suggested I should be seeing much higher chances of success inducting people than I actually was.

The details:
The actual induction to a secret faith is governed by event MNM.3410 in events/mnm_secret_religious_societies_events. Flavor-wise, the inductee reads a holy book for the secret cult's faith, themed with an appeal chosen by the inductor, and chooses either to take on the secret faith himself or to reject it. The weights for each choice are modified by the FROM character's diplomacy, and by a flag they may have indicating that they picked an appropriate argument based on the inductee's character.

The problem is that, as the event chain is coded, the FROM character is not the inductor. MNM.3410 is fired by MNM.3409, another event for the inductee in which they see the holy book and choose whether or not to read it. So when MNM.3410 makes checks against FROM, it's checking the inductee's own stats and flags, rather than the person trying to convince them. This means that high diplomacy does not help in convincing anyone (instead it's easy to convince high-diplomacy people), and that one's choice of argument makes no difference at all, since the flags are being set on the inductor and then checked instead on the inductee.

There are two obvious fixes; the easiest one is to change line 4631, which calls MNM.3410, from

hidden_effect = { character_event = { id = MNM.3410 days = 12 } }

to

hidden_effect = { repeat_event = { id = MNM.3410 days = 12 } }

Making it a 'repeat event' call avoids adding the FROM level that refers to the inductee, so that the FROM scopes in 3410 refer properly to the inductor instead. I've tested this, and it appears to make secret cult induction work more as one would expect, far more reliably on a high-diplomacy character making the correct arguments.

Alternatively, all the FROMs in MNM.3410 can be changed to FROMFROMs. I have not tested that personally, it should work.



------------------

Secondly, MNM.3434 is also somewhat broken. This event is fired when a secret cult member attempts to induct their ward upon reaching age 12, and the child responds poorly to it. The teacher can try again at the cost of a negative modifier, forcing either success or rivalry. The problems here are twofold:

One, it has a tooltip that is meant to display the chances of success and failure. But here, too, it's operating in the wrong scope. MNM.3434 is an event seen by the guardian, and the tooltip attempts to check characteristics of the ward without ever scoping to them. I haven't tested directly, but I believe it needs a FROM = { just inside the tooltip block (and then to remove the two FROMs around each of the displayed effects, since they would then be redundant). As it is, the displayed probabilities seem to be much higher than they should be.

Secondly, the actual chance of success and failure are also being calculated wrong. This is in MNM.3435, which the previous event fires off for the ward. The ai_chance of the second option (failure, rejecting the secret religion) in MNM.3435 is an exact duplicate of the ai_chance in the first option:

ai_chance = {
        	factor = 60
        	modifier = { mother = { character = FROM } factor = 1.6 }
			modifier = { father = { character = FROM } factor = 1.6 }
			modifier = { opinion = { who = FROM value = 30 } factor = 1.5 }
			modifier = { opinion = { who = FROM value = 50 } factor = 1.5 }
			modifier = { opinion = { who = FROM value = 70 } factor = 1.6 }
			modifier = { OR = { trait = trusting trait = affectionate } factor = 2 }
			modifier = { OR = { trait = craven trait = timid } factor = 1.5 }
			modifier = { FROM = { diplomacy = 10 } factor = 1.2 }
			modifier = { FROM = { diplomacy = 12 } factor = 1.2 }
			modifier = { FROM = { diplomacy = 14 } factor = 1.2 }
			modifier = { FROM = { diplomacy = 16 } factor = 1.2 }
			modifier = { FROM = { diplomacy = 18 } factor = 1.2 }
        }

Clearly meant to be improving chances of success when the ward has reason to believe/go along with their guardian. It should instead be using the modifiers used in the tooltip of MNM.3434 for failure:

					modifier = { NOT = { opinion = { who = ROOT value = 0 } } factor = 1.5 }
					modifier = { NOT = { opinion = { who = ROOT value = -20 } } factor = 1.5 }
					modifier = { NOT = { opinion = { who = ROOT value = -40 } } factor = 1.5 }
					modifier = { OR = { trait = zealous trait = idolizer } factor = 5 }
					modifier = { OR = { trait = willful trait = stubborn } factor = 1.5 }
					modifier = { OR = { trait = cynical trait = curious } factor = 1.5 }
					modifier = { ROOT = { NOT = { diplomacy = 8 } } factor = 1.5 }
					modifier = { ROOT = { NOT = { diplomacy = 6 } } factor = 1.5 }

As it is, they simply have a 50/50 chance to accept the faith or become a rival to the ward.

Steps to reproduce the issue.
The first issue is present any time you attempt to induct someone into a secret faith by decision, although it's not particularly obvious due to the random influence that's supposed to be there and the fact that one doesn't know how likely they should be to succeed unless they cross-check against the event files.

The erroneous probabilities in the second issue can occasionally be seen when one of your children grows past age 12 while you have a secret faith - although they have to reject your first attempt to bring them to it, so it isn't guaranteed.

If you examine the files I've referenced, though, the issues should be clear enough.

Upload Attachment

 

[CyberSpyder]

I hope it's all right to bump this for attention, as the issue remains in the code and it rather cripples intentional use of secret cults.