One line summary of your issue
[3.1 KKAD] Wrong probability for success in secret cult induction
Game Version
3.1
What expansions do you have installed?
All of the above
Do you have mods enabled?
No
Please explain your issue is in as much detail as possible.
The chance of success when inducting an AI character into a secret religious society from Monks and Mystics is different (generally substantially lower) than it should be, due to incorrect scopes being used in the event MNM.3410.
This problem is not at all obvious in play, as the intended probability of success is not displayed to the character. Nevertheless, it is an issue that should be addressed.
In more detail: Event MNM.3410 is triggered, eventually, for the 'target' character in a religious society induction, and is the critical event in which they decide to either adopt the secret religion or retain their existing faith.
Their probability of choosing each option is affected by various modifiers keyed off their own traits, and off the character in the FROM scope, intended to be the inductor. Specifically, if the FROM character has high diplomacy, and/or has appropriate character flags indicating the use of an argument suited to the target character, the probability of accepting the secret faith increases. If the FROM character has low diplomacy, it decreases.
The problem with the event is that, as it is coded, the FROM scope points to the wrong character - not the inductor at all, but the target character himself. This is because MNM.3410 is not fired by an event for the inductor, but again for the target character. MNM.3409, the previous event in the chain, has the target character finding a holy book of the secret faith, and deciding whether to read it or hide it; in the former case (which the AI always chooses), they trigger MNM.3410 on themselves. Thus, the FROM scope in that event refers to themself again, rather than to the originator of the conversion attempt.
As such, instead of high diplomacy helping to convert others to a secret faith, it is instead easier to convert characters who have high diplomacy. Worse, the choice of argument made during induction is irrelevant; since it's not checking the flags for the argument on the right character, you can never get the bonus to success for making the right approach.
The issue has an easy fix, which I have confirmed to work in testing. If line 4631 in mnm_secret_religious_societies_events.txt is changed from
hidden_effect = { character_event = { id = MNM.3410 days = 12 } }
to
hidden_effect = { repeat_event = { id = MNM.3410 days = 12 } }
it avoids adding the last FROM on the stack, thereby causing the FROMs in MNM.3410 to refer, correctly, to the inductor character.
Steps to reproduce the issue.
The issue is not one that lends itself to reproduction and visibility in this sense. It's always present when you attempt induction, but it's never particularly apparent unless you go into the code to see that your probability of success is not what it should be.
Upload Attachment
[3.1 KKAD] Wrong probability for success in secret cult induction
Game Version
3.1
What expansions do you have installed?
All of the above
Do you have mods enabled?
No
Please explain your issue is in as much detail as possible.
The chance of success when inducting an AI character into a secret religious society from Monks and Mystics is different (generally substantially lower) than it should be, due to incorrect scopes being used in the event MNM.3410.
This problem is not at all obvious in play, as the intended probability of success is not displayed to the character. Nevertheless, it is an issue that should be addressed.
In more detail: Event MNM.3410 is triggered, eventually, for the 'target' character in a religious society induction, and is the critical event in which they decide to either adopt the secret religion or retain their existing faith.
Their probability of choosing each option is affected by various modifiers keyed off their own traits, and off the character in the FROM scope, intended to be the inductor. Specifically, if the FROM character has high diplomacy, and/or has appropriate character flags indicating the use of an argument suited to the target character, the probability of accepting the secret faith increases. If the FROM character has low diplomacy, it decreases.
The problem with the event is that, as it is coded, the FROM scope points to the wrong character - not the inductor at all, but the target character himself. This is because MNM.3410 is not fired by an event for the inductor, but again for the target character. MNM.3409, the previous event in the chain, has the target character finding a holy book of the secret faith, and deciding whether to read it or hide it; in the former case (which the AI always chooses), they trigger MNM.3410 on themselves. Thus, the FROM scope in that event refers to themself again, rather than to the originator of the conversion attempt.
As such, instead of high diplomacy helping to convert others to a secret faith, it is instead easier to convert characters who have high diplomacy. Worse, the choice of argument made during induction is irrelevant; since it's not checking the flags for the argument on the right character, you can never get the bonus to success for making the right approach.
The issue has an easy fix, which I have confirmed to work in testing. If line 4631 in mnm_secret_religious_societies_events.txt is changed from
hidden_effect = { character_event = { id = MNM.3410 days = 12 } }
to
hidden_effect = { repeat_event = { id = MNM.3410 days = 12 } }
it avoids adding the last FROM on the stack, thereby causing the FROMs in MNM.3410 to refer, correctly, to the inductor character.
Steps to reproduce the issue.
The issue is not one that lends itself to reproduction and visibility in this sense. It's always present when you attempt induction, but it's never particularly apparent unless you go into the code to see that your probability of success is not what it should be.
Upload Attachment
Attachments
Upvote
0
