CK II - [3.2.1 - AZCE] Openly Adopt Faith only converts demesne

[nelliott]

One line summary of your issue
[3.2.1 - AZCE] Hellenic Openly Adopt Faith only converts demesne provinces

Game Version
3.2.1 - AZCE

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
The decision to 'Openly Adopt Faith' is only converting counties with the 'Religious Community' modifier if they are also in my demesne. Non-demesne counties with that modifier are not converted.

In my game, I am the leader of the Hellenic pagan society and also the Byzantine Emperor. I have secretly established Hellenic communities in about 20 of the empire's provinces but when converting only the demesne provinces with that modifier are converted. Non-demesne counties (e.g., Rhegion, Katatheros, Dyrrachion, Rhodos) are not converted. From what I can tell, character religious conversion is as expected, with secret Hellenes publicly converting, so it's just the non-demesne provinces.

From testing, it seems that this issue is not common to all secret societies. From a new game, I was able to reproduce this issue with Hellenic but not Norse. I did some digging in the event files but couldn't find the difference.

Steps to reproduce the issue.
TO REPRODUCE FROM SAVE GAME
1. Load the provided save secret_religion_openly_adopt_faith_bug.ck2
2. Observe that the 'Hellenic Community' modifier exists in several non-demesne provinces in the Byzantine Empire (e.g., Rhegion, Katatheros, Dyrrachion, Rhodos)
3. Enact the 'Openly Adopt Faith' decision
4. Note that only demesne provinces are converted (Sicily, Constantinople, Arborea). Non-demesne provinces with that modifier (e.g., Rhegion, Katatheros, Dyrrachion, Rhodos) are not converted.

TO REPRODUCE FROM NEW GAME (using console & save game edits OR provided save secret_religion_openly_adopt_faith_bug2.ck2)
1. Start new game (tested on Early Middle Ages, Charlemagne)
2. Give player character secret religion #secret_religion 6392 hellenic_pagan
3. Found secret society via decision #prestige 500
4. Add religious community to both demesne and non-demesne provinces #easiest via save-game editing, e.g., secret_hellenic_pagan_community to Maine (108; non-demesne) and Vermandois (113; demesne)
5. Openly Adopt Faith decision
6. Only Vermandois converts if using Hellenic; both Maine and Vermandois convert if Norse

Upload Attachment

 

[nelliott]

I think I found the issue: the limit block in the if statement that handles the Openly Adopt Faith decision doesn't check for hellenic communities.

Lines 468 - 824 of mmm_secret_religious_societies_decisions.txt:

if = {
   limit = {
       is_ruler = yes
       any_demesne_province = {
           OR = {
               AND = {
                   has_province_modifier = secret_catholic_community
                   ROOT = {
                       society_member_of = secret_religious_society_catholic
                   }
               }
              
               AND = {
                   has_province_modifier = secret_cathar_community
                   ROOT = {
                       society_member_of = secret_religious_society_cathar
                   }
               }
              
               AND = {
                   has_province_modifier = secret_fraticelli_community
                   ROOT = {
                       society_member_of = secret_religious_society_fraticelli
                   }
               }
              
               AND = {
                   has_province_modifier = secret_waldensian_community
                   ROOT = {
                       society_member_of = secret_religious_society_waldensian
                   }
               }
              
               AND = {
                   has_province_modifier = secret_lollard_community
                   ROOT = {
                       society_member_of = secret_religious_society_lollard
                   }
               }
              
               AND = {
                   has_province_modifier = secret_orthodox_community
                   ROOT = {
                       society_member_of = secret_religious_society_orthodox
                   }
               }
              
               AND = {
                   has_province_modifier = secret_miaphysite_community
                   ROOT = {
                       society_member_of = secret_religious_society_miaphysite
                   }
               }
              
               AND = {
                   has_province_modifier = secret_monophysite_community
                   ROOT = {
                       society_member_of = secret_religious_society_monophysite
                   }
               }
              
               AND = {
                   has_province_modifier = secret_bogomilist_community
                   ROOT = {
                       society_member_of = secret_religious_society_bogomilist
                   }
               }
              
               AND = {
                   has_province_modifier = secret_monothelite_community
                   ROOT = {
                       society_member_of = secret_religious_society_monothelite
                   }
               }
              
               AND = {
                   has_province_modifier = secret_iconoclast_community
                   ROOT = {
                       society_member_of = secret_religious_society_iconoclast
                   }
               }
              
               AND = {
                   has_province_modifier = secret_paulician_community
                   ROOT = {
                       society_member_of = secret_religious_society_paulician
                   }
               }
              
               AND = {
                   has_province_modifier = secret_nestorian_community
                   ROOT = {
                       society_member_of = secret_religious_society_nestorian
                   }
               }
              
               AND = {
                   has_province_modifier = secret_messalian_community
                   ROOT = {
                       society_member_of = secret_religious_society_messalian
                   }
               }
              
               AND = {
                   has_province_modifier = secret_sunni_community
                   ROOT = {
                       society_member_of = secret_religious_society_sunni
                   }
               }
              
               AND = {
                   has_province_modifier = secret_zikri_community
                   ROOT = {
                       society_member_of = secret_religious_society_zikri
                   }
               }
              
               AND = {
                   has_province_modifier = secret_yazidi_community
                   ROOT = {
                       society_member_of = secret_religious_society_yazidi
                   }
               }
              
               AND = {
                   has_province_modifier = secret_ibadi_community
                   ROOT = {
                       society_member_of = secret_religious_society_ibadi
                   }
               }
              
               AND = {
                   has_province_modifier = secret_kharijite_community
                   ROOT = {
                       society_member_of = secret_religious_society_kharijite
                   }
               }
              
               AND = {
                   has_province_modifier = secret_shiite_community
                   ROOT = {
                       society_member_of = secret_religious_society_shiite
                   }
               }
              
               AND = {
                   has_province_modifier = secret_druze_community
                   ROOT = {
                       society_member_of = secret_religious_society_druze
                   }
               }
              
               AND = {
                   has_province_modifier = secret_hurufi_community
                   ROOT = {
                       society_member_of = secret_religious_society_hurufi
                   }
               }
              
               AND = {
                   has_province_modifier = secret_jewish_community
                   ROOT = {
                       society_member_of = secret_religious_society_jewish
                   }
               }
              
               AND = {
                   has_province_modifier = secret_samaritan_community
                   ROOT = {
                       society_member_of = secret_religious_society_samaritan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_karaite_community
                   ROOT = {
                       society_member_of = secret_religious_society_karaite
                   }
               }
              
               AND = {
                   has_province_modifier = secret_zoroastrian_community
                   ROOT = {
                       society_member_of = secret_religious_society_zoroastrian
                   }
               }
              
               AND = {
                   has_province_modifier = secret_mazdaki_community
                   ROOT = {
                       society_member_of = secret_religious_society_mazdaki
                   }
               }
              
               AND = {
                   has_province_modifier = secret_manichean_community
                   ROOT = {
                       society_member_of = secret_religious_society_manichean
                   }
               }
              
               AND = {
                   has_province_modifier = secret_khurmazta_community
                   ROOT = {
                       society_member_of = secret_religious_society_khurmazta
                   }
               }
              
               AND = {
                   has_province_modifier = secret_bon_community
                   ROOT = {
                       society_member_of = secret_religious_society_bon
                   }
               }
              
               AND = {
                   has_province_modifier = secret_taoist_community
                   ROOT = {
                       society_member_of = secret_religious_society_taoist
                   }
               }
              
               AND = {
                   has_province_modifier = secret_hindu_community
                   ROOT = {
                       society_member_of = secret_religious_society_hindu
                   }
               }
              
               AND = {
                   has_province_modifier = secret_buddhist_community
                   ROOT = {
                       society_member_of = secret_religious_society_buddhist
                   }
               }
              
               AND = {
                   has_province_modifier = secret_jain_community
                   ROOT = {
                       society_member_of = secret_religious_society_jain
                   }
               }
              
               AND = {
                   has_province_modifier = secret_norse_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_norse_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_norse_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_norse_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_baltic_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_baltic_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_baltic_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_baltic_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_finnish_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_finnish_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_finnish_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_finnish_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_slavic_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_slavic_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_slavic_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_slavic_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_tengri_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_tengri_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_tengri_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_tengri_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_west_african_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_west_african_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_west_african_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_west_african_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_zun_pagan_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_zun_pagan_reformed
                   }
               }
              
               AND = {
                   has_province_modifier = secret_zun_pagan_community
                   ROOT = {
                       society_member_of = secret_religious_society_zun_pagan
                   }
               }
              
               AND = {
                   has_province_modifier = secret_aztec_community
                   ROOT = {
                       society_member_of = secret_religious_society_aztec
                   }
               }
              
               AND = {
                   has_province_modifier = secret_aztec_reformed_community
                   ROOT = {
                       society_member_of = secret_religious_society_aztec_reformed
                   }
               }
           }
       }
   }
   <code that handles conversion>