CK II - Errors in succession voting scripting for culturist opinion penalties [3.3.2]

[redtide]

One line summary of your issue
Errors in succession voting scripting for culturist opinion penalties [3.3.2]

Game Version
3.3.2

What expansions do you have installed?
All of the above

Do you have mods enabled?
Yes

Please explain your issue is in as much detail as possible.

01_succession_voting_specials.txt has errors in "culturism" opinion penalties. I first noticed them for Princely Elective (HRE) succession, but some of them also exist for Byzantine and in 00_succession_voting.txt for regular feudal elective, elective gavelkind, and tanistry.

At line 5441, remove the NOT = { }.
The capital being referenced is that of the elector rather than that of the candidate. Compare it to the previous two modifiers. As written, it says that the elector will make this judgment about a candidate only when the elector's own capital is not in the de jure territory of the contested title, which makes no sense. It should be the opposite, as is the case for the "Candidate is a foreign ruler" penalty.

On lines 5422, 5426, 5432, and 5441, change de_jure_liege to de_jure_liege_or_above.
The former is too narrow, evaluating as true only for direct de jure vassals.

On line 5425, change FROMFROM to ROOT_FROMFROM.

Also on line 5425, can the "vassal_of" condition take a title instead of a character? If not, maybe change it to de_facto_liege_title.

The "Candidate is a foreign non-dejure ruler" modifier does not actually check for de jure status (again note that the capital clause refers to the capital of the elector and not that of the candidate), so add something like:

FROMFROM = {
    NOT = { de_jure_vassal_or_below = ROOT_FROM }
}

and then add its opposite to the "Candidate is a foreign ruler" modifier to avoid overlap.
(I don't know how "is_vassal_or_below_of" works, but it seems to be checking only de facto status.)

Steps to reproduce the issue.


Upload Attachment

 

[redtide]

for Elective Gavelkind and Tanistry, the conditions for "tooltip_feudal_elector_vote_strangers_pet" (and "tooltip_feudal_elector_vote_foreigners_pet" for Tanistry) are contradictory:

FROMFROM = { holder_scope = { culture = ROOT } }

i.e. the current ruler is the same culture as the voter, and

FROM = { culture = ROOT }

i.e. the candidate is the same culture as the voter

together these imply that the current ruler is the same culture as the candidate, but then we get

FROMFROM = { holder_scope = { NOT = { culture = ROOT_FROM } } }

i.e. the current ruler is not the same culture as the candidate

The condition that the current ruler be the same culture as the voter should be removed.

 

[redtide]

It would be easier to mod these if they were in scripted triggers instead of separate instances for each of the succession voting schemes. And it might avoid a bug getting fixed for one scheme but not for another.