Correcting Deprecated Commands

[Therion]

Many of the events in AGCEEP still use deprecated commands.

Correcting secedeprovince to cedeprovince is very easy.

Open notepad++ and press CTRL + F, go to 'Find in Files' and browse for AGCEEP\Events directory, as shown below...

...and select 'Replace in Files'.

The 'addcore/removecore' commands and 'core' triggers are a bit trickier as now there are three possibilites. All the events involving cores need to be reviewed and selections made on whether cores are to be given as national, claim or casusbelli. Since 'core_national' functions exactly like the deprecated 'core' command/trigger, it can be used to mass-replace 'core', then be reviewed afterwards.

 

[Bordic]

Yes, I agree. But about the addcore/remove core I suggest to use a blank space after the word "core" as in this case the "core_national" won't be replaced with "core_national_national"...

That is "core " replaced by "core_national ".

 

[ConjurerDragon]

Many of the events in AGCEEP still use deprecated commands.

Correcting secedeprovince to cedeprovince is very easy.

Open notepad++ and press CTRL + F, go to 'Find in Files' and browse for AGCEEP\Events directory, as shown below...
...
...and select 'Replace in Files'.

The 'addcore/removecore' commands and 'core' triggers are a bit trickier as now there are three possibilites. All the events involving cores need to be reviewed and selections made on whether cores are to be given as national, claim or casusbelli. Since 'core_national' functions exactly like the deprecated 'core' command/trigger, it can be used to mass-replace 'core', then be reviewed afterwards.

As long as addcore or cede or other old commands still work I see no need to hurry anything except to make sure that the old commands are not used in new events and to change them in old events if we have to change anything else in the old event.

 

[Bordic]

There are 257 event files in agceep. We'll never change them all definitively if we only modify the old events that need to be improved with new triggers.

 

[Garbon]

I think CD is right though. There isn't really much to be gained by changing all add remove core lines to _national. Secede to cede, yes but not the later seeing as how the issue of what we actually want them to mean still exists.

 

[Bordic]

OK. Then secede to cede only. Cores will be revised one by one when needed.

 

[Toio]

As long as addcore or cede or other old commands still work I see no need to hurry anything except to make sure that the old commands are not used in new events and to change them in old events if we have to change anything else in the old event.

you sure addcore still works?

does it become a national core after 360 months?

 

[MichaelM]

"secedeprovince" was renamed "cedeprovince" simply because, grammatically speaking, you can't "secede" a province to another country (though you can secede from a country). They are functionally equivalent, as are "addcore" and "addcore_national". (And the "core" and "core_national" triggers.)

 

[Garbon]

"secedeprovince" was renamed "cedeprovince" simply because, grammatically speaking, you can't "secede" a province to another country (though you can secede from a country).

Yeah it was clearly an artifact of non-native English.

 

[Toio]

"secedeprovince" was renamed "cedeprovince" simply because, grammatically speaking, you can't "secede" a province to another country (though you can secede from a country). They are functionally equivalent, as are "addcore" and "addcore_national". (And the "core" and "core_national" triggers.)

So, the addcore is the same as addcore_national and is thus linked with defines files to become a national core after 360 months

 

[ConjurerDragon]

So, the addcore is the same as addcore_national and is thus linked with defines files to become a national core after 360 months

No the addcore_national gives a nationalcore immediately. The core_claim does become a national core *if the province if owned by the state that has the core* after 30 years.
http://forum.paradoxplaza.com/forum...ggers-list&p=10731871&viewfull=1#post10731871

 

[Toio]

No the addcore_national gives a nationalcore immediately. The core_claim does become a national core *if the province if owned by the state that has the core* after 30 years.
http://forum.paradoxplaza.com/forum...ggers-list&p=10731871&viewfull=1#post10731871

thanks, that what I thought.

so, addcore and addcore_claim are identical in that after 30 year sthey become national core.

Then we do not need to really use addcore_national on the lands of aragon ( as Spain ), because historically, SPA did not own these lands as the union of Ferdinand and Isabella was a "confederation". This is why after isabella death ferdinand tried to remarry IIRC into the house of Navarre or Foix.

On TUR events we might as well leave them as the old addcore

 

[MichaelM]

I said that addcore and addcore_national are equivalent:

They are functionally equivalent, as are "addcore" and "addcore_national". (And the "core" and "core_national" triggers.)

I did not at any point say that addcore is the same as addcore_claim.

National cores were the only type of cores that EU2 had, unless you count the Treaty of Tordesillas claims.

 

[Toio]

I said that addcore and addcore_national are equivalent:

I did not at any point say that addcore is the same as addcore_claim.

National cores were the only type of cores that EU2 had, unless you count the Treaty of Tordesillas claims.

I am not saying anything on what people say, all I want to know is if addcore and addcore_claim are the same due to the fact of .......do i need to change all the old events that have addcore to addcore_claim....as I see the same end result for both commands after 360 months of ownership for a nation.

or

is "old" addcore = addcore_national

 

[ConjurerDragon]

I am not saying anything on what people say, all I want to know is if addcore and addcore_claim are the same due to the fact of .......do i need to change all the old events that have addcore to addcore_claim....as I see the same end result for both commands after 360 months of ownership for a nation.

No. the old addcore is not the same as the new addcore_claim. As MichaelM tried to explain the old EU2 "addcore" command can only be the same as addcore_national because in the old game there was only 1 type of core and that was a national core.

is "old" addcore = addcore_national

Yes, the old addcore is the same as the new addcore_national.

 

[Bordic]

I believe that Toio is asking if after 30 years "old" core becomes "core_national" and then ftg engine recognizes it as typed "core_national".

In this way, will a trigger testing "core" work the same in case the core is actually "core_national"?

 

[MichaelM]

There is no "old" core vs. "core_national". There is only one national core type which can be added, removed, or checked through two different names.

Core = core_national.
Core_claim is different. After 30 years of ownership, a core_claim becomes a core_national, which is also a just plain "core".
Core_casusbelli is different. It never changes except by event.
Religious cores are different and can't be added or removed by event.

 

[Toio]

There is no "old" core vs. "core_national". There is only one national core type which can be added, removed, or checked through two different names.

Core = core_national.
Core_claim is different. After 30 years of ownership, a core_claim becomes a core_national, which is also a just plain "core".
Core_casusbelli is different. It never changes except by event.
Religious cores are different and can't be added or removed by event.

I am also asking because if an old event has an addcore , can I use command = { type = removecore_national which = x } to remove this addcore or do I need to amend these addcore to addcore_national ones first.

 

[Bordic]

I am also asking because if an old event has an addcore , can I use command = { type = removecore_national which = x } to remove this addcore or do I need to amend these addcore to addcore_national ones first.

I think he said you can use both types as triggers or commands indifferently:

There is only one national core type which can be added, removed, or checked through two different names.

 

[Pied-Noir]

'type = removecore' will remove any core, you need not distinguish.