How do you scope to a general at the end of a ground battle victory?

[Pancakelord]

So, because I love pain, I'm trying to setup a few "battle awarded" traits for generals.

The basic premise is I run this when either side wins a ground battle (or, put another way, this script runs for the winner always - need to add a trigger for default countries only, later).

My goal in the red bit below, is to try and scope to the general of the winning army in a ground invasion so I can give them a trait. This doesnt work.

However, it doesnt scope to the general - possibly because they return to orbit on-victory. I think I've been staring at this too long and need a fresh perspective. Does anyone know of a less messy (and actually workable) way to scope to a general, from a planet, using the above 2 on-actions?

 

[OldEnt]

Try:

# Triggers when ground combat starts
# This = planet
# From = country attacking
on_ground_combat_started = {
}

and track generals from there.

This can also help in tracking additional generals joining later:

#An army has been killed in ground combat
# This = owner
# From = army
# FromFrom = opponent
# FromFromFrom = planet
on_army_killed_in_combat = {
    events = {
        emperor.450
        necroids.15
    }
}

 

[Pancakelord]

Try:

# Triggers when ground combat starts
# This = planet
# From = country attacking
on_ground_combat_started = {
}

and track generals from there.

This can also help in tracking additional generals joining later:

#An army has been killed in ground combat
# This = owner
# From = army
# FromFrom = opponent
# FromFromFrom = planet
on_army_killed_in_combat = {
    events = {
        emperor.450
        necroids.15
    }
}

thanks I'll give that a go. Even more direct scope grabs dont work for some reason when i re-write it like this.

Right now my test setup is 7 clone armies invading a world. I have a feeling I can directly grab the generals on the defender side - if they win - as they should "be" on the planet (from what I gather, generals are never "on" planets. They're always attached to an army, which is, in-turn, on a planet).

 

[Pancakelord]

Ah figured it out!. Now my general will gain an affinity fighting on cold worlds whenever he wins a fight on one cold one (there's a little more to it than that, but yeah)

The trait will rank up after 5, and then 10 victories on an arctic world (+50%/+75% army dmg, rather than the base +25%, on cold worlds).

so - for anyone interested - my general ID script, still using on_planet_attackers_win / on_planet_defenders_win [need to test def side] on actions, is as follows:

One last question, unanswered, is what happens with general selection in multi-army scenarios. like with 2-3 armies defending / attacking. A very rare event, will have to figure out a good way to test it.