Incorrect development penalty when converting faith

[jimmycarr]

Information​

I have verifed my game files (Steam only)​

Yes

I have disabled all mods​

Yes

I am running the latest game update​

Yes

Required​

Summary​

Incorrect development penalty when converting faith

Description​

The convert_faith_development_penalty script value is being incorrectly calculated when the liege has the Zealous Proselytizer perk (or the reformer_conversion flag). The reason for this is that the court_chaplain_conversion_monthly_increase_perk_bonus value is being double-counted - it's already included in the scope:councillor.court_chaplain_conversion_contextual_bonuses calculation but is being added separately.

This can significantly affect county conversion and it's actually better not to have the perk, at least at higher county development levels.

Steps to reproduce​

1. Have a character with the Zealous Proselytizer perk
2. Start converting a county
3. The "From Development" penalty will be incorrect. It should be (all bonuses including Zealous Proselytizer) * (county development / 100). However, it's actually ((all bonuses including Zealous Proselytizer) + (Zealous Proselytizer bonus)) * (county development / 100)

Game Version​

1.14.2.2

Platform​

Windows

Additional Information​

Affected Feature​

• Gameplay

Save Game​

Other Attachments​

 

[CirclePete]

Came to the same conclusion while looking in 99_court_chaplain_values.txt

The line add = scope:councillor.court_chaplain_conversion_monthly_increase_perk_bonus is indeed redundant.

On the example below, before the penalty, with 105% in bonuses, the progression should be (0.5+0.34)*(1+1.05) = 7.995
With the miscalculation of the penalty, the bonuses is considered to be 130% (105% + duplicate 25%), so the penalty (capped at 90%) is (0.5+034)*(1+1.3)*0.9 = 8.073

It gives a negative progression, of -0.078, when it should be +0.7995.