oil reserves event broken?

[taffy3]

So the Naval Oil reserve event warns you that when you're at war, you need to stockpile a certain amount of oil, per number of heavy capital ships.

The events that actually detect when you go under/over that amount, and then penalize/restore your naval unit stats, seems to be broken. Apparently the penalization event repeatedly fires every 15(?) days if you don't fix your oil situation... and so the penalties compound. But the restoration event only fires once, and only fixes one penalty event's worth of penalties.

For e.g. I was playing a UK game. Oil stockpile dipped under the magic number. Penalty fired. My '42 carrier went from a range of 5500 to 3500. The event fired again after a bunch of days and my range went down further. When I fixed my oil situation, a single restore event fired, bumping my CV range back up to 3500. But no subsequent restore event fired to get me to 5500.

Is there any way to fix this?

 

[Fernando Torres]

Can you please post both events here? I'll see what i can do.

 

[taffy3]

I believe it's these three events, located in db/WIF/Fernando_Torres_Special.txt

-->

#############################################################################
# Naval Fuel Requirements (by LMoore, based on original by Dec152000) FROM EPSILON MOD
#############################################################################
event = {
        id = 2267
        random = no
        persistent = yes

        name = "2267name"
        desc = "2267desc"
        picture = "USSPennsylvania"

        trigger = {
                                ai = no
                atwar = yes
                NOT = { local_flag = Navy_Fuel_OK }
                NOT = { local_flag = Navy_Fuel_Need }
                OR = {
                        country = AST
                        country = ARG
                        country = BRA
                        country = CAN
                        country = CHI
                        country = CHC
                        country = ENG
                        country = FRA
                        country = GER
                        country = HOL
                        country = ITA
                        country = JAP
                        country = RUS
                        country = SCA
                        country = SPA
                        country = SPR
                        country = SWE
                        country = SOV
                        country = USA
                }
                OR = {
                        carrier = 3
                        battleship = 4
                        battlecruiser = 5
                        heavy_cruiser = 8
                }
        }


        date = { day = 1 month = january  year = 1930 }
        offset = 6
        deathdate = { day = 30 month = december year = 1960 }

        action_a = {
                name = "OK"
                command = { type = local_setflag which = Navy_Fuel_OK }
                command = { type = local_clrflag which = Navy_Fuel_Need }
                
        }
}

event = {
        id = 2268
        random = no
        persistent = yes

        name = "2268name"
        desc = "2268desc"
        style = 0
        picture = "USSPennsylvania"


        trigger = {
                                ai = no
                local_flag = Navy_Fuel_OK
                NOT = { oil = 5000 } 

                OR = {
                        country = AST
                        country = ARG
                        country = BRA
                        country = CAN
                        country = CHI
                        country = CHC
                        country = ENG
                        country = FRA
                        country = GER
                        country = HOL
                        country = ITA
                        country = JAP
                        country = RUS
                        country = SCA
                        country = SWE
                        country = SOV
                        country = USA
                }


                OR = {
                        AND = {
                                NOT = { oil = 1000 } 
                                OR = {
                                        carrier = 3
                                        battleship = 4
                                        battlecruiser = 5
                                        heavy_cruiser = 8
                                }
                        }
                        AND = {
                                NOT = { oil = 2000 } 
                                OR = {
                                        carrier = 6
                                        battleship = 8
                                        battlecruiser = 10
                                        heavy_cruiser = 16
                                }
                        }
                        AND = {
                                NOT = { oil = 3000 } 
                                OR = {
                                        carrier = 9
                                        battleship = 12
                                        battlecruiser = 15
                                        heavy_cruiser = 24
                                }
                        }
                        AND = {
                                NOT = { oil = 4000 } 
                                OR = {
                                        carrier = 12
                                        battleship = 16
                                        battlecruiser = 20
                                        heavy_cruiser = 32
                                }
                        }
                        AND = {
                                NOT = { oil = 5000 } 
                                OR = {
                                        carrier = 15
                                        battleship = 20
                                        battlecruiser = 25
                                        heavy_cruiser = 40
                                }
                        }
                }
        }

        date = { day = 1 month = january  year = 1930 }
        offset = 15
        deathdate = { day = 30 month = december year = 1960 }

        action_a = {
                name = "evtMERDE"

                command = { type = surprise which = naval value = -20 }
                command = { type = range which = battleship value = -2000 }
                command = { type = range which = battlecruiser value = -2000 }
                command = { type = range which = heavy_cruiser value = -2000 } 
                command = { type = range which = carrier value = -2000 }

                command = { type = max_positioning which = battleship value = -0.2 }
                command = { type = min_positioning which = battleship value = -0.2 }
                command = { type = max_positioning which = battlecruiser value = -0.2 }
                command = { type = min_positioning which = battlecruiser value = -0.2 }
                command = { type = max_positioning which = heavy_cruiser value = -0.2 }
                command = { type = min_positioning which = heavy_cruiser value = -0.2 }
                command = { type = max_positioning which = carrier value = -0.3 }
                command = { type = min_positioning which = carrier value = -0.3 }
                command = { type = morale which = battleship value = -20 }
                command = { type = morale which = battlecruiser value = -20 }
                command = { type = morale which = heavy_cruiser value = -20 } 
                command = { type = morale which = carrier value = -20 }

                command = { type = max_organization which = battleship value = -20 }
                command = { type = max_organization which = battlecruiser value = -20 }
                command = { type = max_organization which = heavy_cruiser value = -20 }
                command = { type = max_organization which = carrier value = -20 }

                command = { type = local_setflag which = Navy_Fuel_Need }
                command = { type = local_clrflag which = Navy_Fuel_OK }
        }
}

event = {
        id = 2269
        random = no
        persistent = yes

        name = "2269name"
        desc = "2269desc"
        style = 0
        picture = "USSPennsylvania"

        trigger = {
                                ai = no
                local_flag = Navy_Fuel_Need
                OR = {
                        country = AST
                        country = ARG
                        country = BRA
                        country = CAN
                        country = CHI
                        country = CHC
                        country = ENG
                        country = FRA
                        country = GER
                        country = HOL
                        country = ITA
                        country = JAP
                        country = RUS
                        country = SCA
                        country = SWE
                        country = SOV
                        country = USA
                }

                OR = {
                        AND = {
                                NOT = { carrier = 3 }
                                NOT = { battleship = 4 }
                                NOT = { battlecruiser = 5 }
                                NOT = { heavy_cruiser = 8 }
                        }
                        AND = {
                                oil = 1500
                                OR = {
                                        carrier = 3
                                        battleship = 4
                                        battlecruiser = 5
                                        heavy_cruiser = 8
                                }
                        }
                        AND = {
                                oil = 3000
                                OR = {
                                        carrier = 6
                                        battleship = 8
                                        battlecruiser = 10
                                        heavy_cruiser = 16
                                }
                        }
                        AND = {
                                oil = 4500
                                OR = {
                                        carrier = 9
                                        battleship = 12
                                        battlecruiser = 15
                                        heavy_cruiser = 24
                                }
                        }
                        AND = {
                                oil = 6000
                                OR = {
                                        carrier = 12
                                        battleship = 16
                                        battlecruiser = 20
                                        heavy_cruiser = 32
                                }
                        }
                        AND = {
                                oil = 7500
                                OR = {
                                        carrier = 15
                                        battleship = 20
                                        battlecruiser = 25
                                        heavy_cruiser = 40
                                }
                        }
                }
        } 

        date = { day = 1 month = january  year = 1930 }
        offset = 15
        deathdate = { day = 30 month = december year = 1960 }

        action_a = {
                name = "Excellent"

                command = { type = surprise which = naval value = 20 }
                command = { type = range which = battleship value = 2000 }
                command = { type = range which = battlecruiser value = 2000 }
                command = { type = range which = heavy_cruiser value = 2000 } 
                command = { type = range which = carrier value = 2000 }

                command = { type = max_positioning which = battleship value = 0.2 }
                command = { type = min_positioning which = battleship value = 0.2 }
                command = { type = max_positioning which = battlecruiser value = 0.2 }
                command = { type = min_positioning which = battlecruiser value = 0.2 }
                command = { type = max_positioning which = heavy_cruiser value = 0.2 }
                command = { type = min_positioning which = heavy_cruiser value = 0.2 }
                command = { type = max_positioning which = carrier value = 0.3 }
                command = { type = min_positioning which = carrier value = 0.3 }
                command = { type = morale which = battleship value = 20 }
                command = { type = morale which = battlecruiser value = 20 }
                command = { type = morale which = heavy_cruiser value = 20 } 
                command = { type = morale which = carrier value = 20 }

                command = { type = max_organization which = battleship value = 20 }
                command = { type = max_organization which = battlecruiser value = 20 }
                command = { type = max_organization which = heavy_cruiser value = 20 }
                command = { type = max_organization which = carrier value = 20 }

                command = { type = local_clrflag which = Navy_Fuel_Need }
                command = { type = local_setflag which = Navy_Fuel_OK }
        }
}

 

[Fernando Torres]

The events look good so I have no idea where the bug comes from.
You can type "event 2269" in the console (f12) to solve this.

 

[taffy3]

The events look good so I have no idea where the bug comes from.
You can type "event 2269" in the console (f12) to solve this.

Yeah, that's what I ended up doing. No biggy.