oversee preparation task can gives random bonus

[ourg]

Information​

I have verifed my game files (Steam only)​

Yes

I have disabled all mods​

Yes

I am running the latest game update​

Yes

Required​

Summary​

oversee preparation task can gives random bonus

Description​

the oversee preparation task sometime gives the bonus of another season randomly

Steps to reproduce​

have a stargazer, enable the oversee preparation multiple times and look at the effect

Game Version​

1.16.2.2

Platform​

Windows

Additional Information​

Affected Feature​

• Gameplay

Save Game​

Other Attachments​

 

[ourg]

here the season is everlasting summer :

and the bonus modifier is for servere drought :

if i click on/off multiple time seometime the right bonus is applied :

 

[ourg]

I think the random_county_situation_sub_region is buged

I've fixed the issue by replacer the court_astrologer_task_add_seasonal_modifiers_effect

court_astrologer_task_add_seasonal_modifiers_effect = {
    hidden_effect = {
        save_scope_as = current_character
        capital_province.county = {
            random_county_situation_sub_region = {
                limit = {
                    OR = {
                        sub_region_current_phase = situation_steppe_abundant_grazing_season
                        sub_region_current_phase = situation_steppe_warm_nights_season
                        sub_region_current_phase = situation_steppe_sky_blessing_season
                        sub_region_current_phase = situation_steppe_white_zud_season
                        sub_region_current_phase = situation_steppe_cold_zud_season
                        sub_region_current_phase = situation_steppe_severe_drought_season
                        sub_region_current_phase = situation_steppe_havsarsan_zud_season
                    }
                }
                switch = {
                    trigger = sub_region_current_phase
                    situation_steppe_abundant_grazing_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_abundant_grazing_modifier
                        }
                    }
                    situation_steppe_warm_nights_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_warm_nights_modifier
                        }
                    }
                    situation_steppe_sky_blessing_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_sky_blessing_modifier
                        }
                    }
                    situation_steppe_white_zud_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_white_zud_modifier
                        }
                    }
                    situation_steppe_cold_zud_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_cold_zud_modifier
                        }
                    }
                    situation_steppe_severe_drought_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_severe_drought_modifier
                        }
                    }
                    situation_steppe_havsarsan_zud_season = {
                        scope:current_character = {
                            add_character_modifier = court_astrologer_havsarsan_zud_modifier
                        }
                    }
                }
            }
        }
    }
}

by

court_astrologer_task_add_seasonal_modifiers_effect = {
    hidden_effect = {
        save_scope_as = current_character
        capital_province.county ?= {
        if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_abundant_grazing_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_abundant_grazing_modifier
            }
        }
        else_if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_warm_nights_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_warm_nights_modifier
            }
        }
        else_if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_sky_blessing_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_sky_blessing_modifier
            }
        }
        else_if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_white_zud_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_white_zud_modifier
            }
        }
        else_if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_cold_zud_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_cold_zud_modifier
            }
        }
        else_if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_severe_drought_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_severe_drought_modifier
            }
        }
        else_if = {
            limit = {
                any_county_situation = {
                    any_situation_sub_region = {
                        sub_region_current_phase = situation_steppe_havsarsan_zud_season
                        situation_sub_region_has_county = scope:current_character.capital_county
                    }
                }
            }
            scope:current_character = {
                    add_character_modifier = court_astrologer_havsarsan_zud_modifier
            }
        }
        }
    }
}

and now it works