question about modding: mod didn't work

[Depressed_teen]

i'm making a mod about custom holy order, the decision to make it exist, the cost also work. the random generated character also there but it didn't show at the holy table, he is only landless character with duke tier title, i attached the file here. also how to make the decision disappear after we click it?

 

[Silversweeeper]

i'm making a mod about custom holy order, the decision to make it exist, the cost also work. the random generated character also there but it didn't show at the holy table, he is only landless character with duke tier title, i attached the file here. also how to make the decision disappear after we click it?

A holy order needs to have a religion set to show up as a holy order for any religion, which yours doesn't have. "d_custom_holy_order = { religion = <scope> }" with a proper scope (e.g. ROOT) and no quotation marks as soon as the title is handed out should work, though as vanilla doesn't have any noreligion holy orders it's possible things will end up weirdly if you hand out a noreligion holy order.

As for making the decision only show up prior to the holy order being created, that depends on the overall implementation. If the decision is meant to be taken once only, you could set a global flag when creating the holy order and check whether that same flag is set in the potential. If it's possible for the holy order to be deactivated and desirable for it to be possible to recreate it in that case, checking for the title being active would be better, though as currently implemented that'll make the decision always fail since you've not deactivated the title and it has "landless = yes"; you most likely don't want a noreligion holy order around, so deactivating it similarly to how vanilla deactivates its holy orders would be prudent.

 

[Depressed_teen]

A holy order needs to have a religion set to show up as a holy order for any religion, which yours doesn't have. "d_custom_holy_order = { religion = <scope> }" with a proper scope (e.g. ROOT) and no quotation marks as soon as the title is handed out should work, though as vanilla doesn't have any noreligion holy orders it's possible things will end up weirdly if you hand out a noreligion holy order.

As for making the decision only show up prior to the holy order being created, that depends on the overall implementation. If the decision is meant to be taken once only, you could set a global flag when creating the holy order and check whether that same flag is set in the potential. If it's possible for the holy order to be deactivated and desirable for it to be possible to recreate it in that case, checking for the title being active would be better, though as currently implemented that'll make the decision always fail since you've not deactivated the title and it has "landless = yes"; you most likely don't want a noreligion holy order around, so deactivating it similarly to how vanilla deactivates its holy orders would be prudent.

Thank you for the help, I want the decision exist from the start but once we click it the decision gone. How to do it?

Also it still didn't show up in holy order tab after I add the religion scope, is it because game mechanic?

 

[Silversweeeper]

Thank you for the help, I want the decision exist from the start but once we click it the decision gone. How to do it?

Then assuming you deactivate the title in the title history -- again, you probably don't want a noreligion holy order to be active, seeing as anything noreligion can result in issues -- adding a check for the title being active in the potential -- similar to what vanilla has for assorted holy orders that can be created by decision -- and activating the title as the first step when the decision is taken -- check how vanilla does it -- should hide the decision permanently once it has been taken.

Also it still didn't show up in holy order tab after I add the religion scope, is it because game mechanic?

Odd; "d_custom_holy_order = { religion = ROOT }" (no quotation marks) should work per the wiki, though in theory the command could be broken or holy orders might work weirdly if they start out as noreligion holy orders.

Try the following (if something works, don't continue down the list):

- Leave "d_custom_holy_order = { religion = ROOT }" in the decision and put "religion = catholic" in the landed_titles definition for your holy order. Try the decision with a non-Catholic character; if the holy order shows up in the holy order tab after you've taken the decision, it works.

- Change "d_custom_holy_order = { religion = ROOT }" to e.g. "d_custom_holy_order = { religion = orthodox }" without the "religion = catholic" in the landed_titles definition for the holy order and test it with a character whose religion matches the religion you set in the decision; if this works, it can be made to work regardless of the decision taker's religion, but it's not worth doing the extra work to set that up ahead of confirming that the general approach works works.

- Change "d_custom_holy_order = { religion = ROOT }" to e.g. "d_custom_holy_order = { religion = orthodox }" and put "religion = catholic" in the landed_titles definition for the holy order and test it with a character whose religion matches the religion you set in the decision; again, if this works, it's possible to extend it to make it work for other religions.

If none of the above works, it's possible there are hardcoded limitations to holy order religions; vanilla never have them change religion outside two special cases -- heresy takeovers resulting in the holy orders switching to the new mainstream plus the Jomsvikings converting when the Norse reform -- and doesn't change title religions in script outside those case, so in theory the "religion = <whatever>" command might not work as expected for titles.

 

[Depressed_teen]

Then assuming you deactivate the title in the title history -- again, you probably don't want a noreligion holy order to be active, seeing as anything noreligion can result in issues -- adding a check for the title being active in the potential -- similar to what vanilla has for assorted holy orders that can be created by decision -- and activating the title as the first step when the decision is taken -- check how vanilla does it -- should hide the decision permanently once it has been taken.



Odd; "d_custom_holy_order = { religion = ROOT }" (no quotation marks) should work per the wiki, though in theory the command could be broken or holy orders might work weirdly if they start out as noreligion holy orders.

Try the following (if something works, don't continue down the list):

- Leave "d_custom_holy_order = { religion = ROOT }" in the decision and put "religion = catholic" in the landed_titles definition for your holy order. Try the decision with a non-Catholic character; if the holy order shows up in the holy order tab after you've taken the decision, it works.

- Change "d_custom_holy_order = { religion = ROOT }" to e.g. "d_custom_holy_order = { religion = orthodox }" without the "religion = catholic" in the landed_titles definition for the holy order and test it with a character whose religion matches the religion you set in the decision; if this works, it can be made to work regardless of the decision taker's religion, but it's not worth doing the extra work to set that up ahead of confirming that the general approach works works.

- Change "d_custom_holy_order = { religion = ROOT }" to e.g. "d_custom_holy_order = { religion = orthodox }" and put "religion = catholic" in the landed_titles definition for the holy order and test it with a character whose religion matches the religion you set in the decision; again, if this works, it's possible to extend it to make it work for other religions.

If none of the above works, it's possible there are hardcoded limitations to holy order religions; vanilla never have them change religion outside two special cases -- heresy takeovers resulting in the holy orders switching to the new mainstream plus the Jomsvikings converting when the Norse reform -- and doesn't change title religions in script outside those case, so in theory the "religion = <whatever>" command might not work as expected for titles.

Thank you for the advice man. I checked everything up. so I try again then it work. The order exist in holy order tab. The next problem I still facing is just the decision. I already set the title inactive in history copying the teutonic, and add the potential set to {any_demense_title = COUNT}, and the decision still there after click it

 

[Silversweeeper]

Thank you for the advice man. I checked everything up. so I try again then it work. The order exist in holy order tab. The next problem I still facing is just the decision. I already set the title inactive in history copying the teutonic, and add the potential set to {any_demense_title = COUNT}, and the decision still there after click it

"any_demesne_title = COUNT" is completely irrelevant to disabling the decision; you simply want to check that the title is inactive, as if it isn't then the decision has already been used (or you've activated it in another manner, in which case the decision presumably also should be disabled).

 

[Depressed_teen]

"any_demesne_title = COUNT" is completely irrelevant to disabling the decision; you simply want to check that the title is inactive, as if it isn't then the decision has already been used (or you've activated it in another manner, in which case the decision presumably also should be disabled).

I see. Do you have suggestions? Should I change it to only king can do it? Or adding tag same like the default holy order?

 

[Silversweeeper]

I see. Do you have suggestions? Should I change it to only king can do it? Or adding tag same like the default holy order?

The only bit you need in the potential (aside from what you had originally) is the check for the title being active; the tier of the decision-taker is irrelevant.

 

[Depressed_teen]

The only bit you need in the potential (aside from what you had originally) is the check for the title being active; the tier of the decision-taker is irrelevant.

Okay. Thank you for your help so far man