Surviving Mars - Missed a reference to SupplyRocket

[ChoGGi_2]

Description
Missed a reference to SupplyRocket


Windows


Steam

What is your game version?
Tito hotfix 4

Do you have Space Race installed?
Yes

Please explain your issue is in as much detail as possible.
Changing the SupplyRocket class name to RocketBase means sometimes missing a reference or two

[LUA ERROR] Mars/Lua/Buildings/RocketTrade.lua:71: attempt to call a nil value (field 'OnModifiableValueChanged')

function TradeRocket:OnModifiableValueChanged(prop, ...)
    if prop ~= "max_export_storage" then
        SupplyRocket.OnModifiableValueChanged(self, prop, ...)
    end
end

https://www.reddit.com/r/SurvivingMars/comments/obb7hx

Can you replicate the issue?
Yes


Edit:
Found two more

function RocketExpedition:OnDemolish()
  ClearDestroyedExpeditionRocketSpot(self)
  SupplyRocket.OnDemolish(self)
end

function ForeignTradeRocket:OnModifiableValueChanged(prop, ...)
  if prop ~= "max_export_storage" and prop ~= "launch_fuel" then
    SupplyRocket.OnModifiableValueChanged(self, prop, ...)
  end
end

 

[AndrewT]

I can't say I see the connection between your description and that Reddit report - you're way over my head!

I wonder if we can get a layman's description of the core of the bug? Or do I not need to know that, I should just pass it on as is?

 

[ChoGGi_2]

From his log file:
[LUA ERROR] Mars/Lua/Buildings/RocketTrade.lua:71: attempt to call a nil value (field 'OnModifiableValueChanged')


Line 71 of RocketTrade.lua is calling a nonexistent func
SupplyRocket.OnModifiableValueChanged(self, prop, ...)
It should probably be this instead:
RocketBase.OnModifiableValueChanged(self, prop, ...)

Like this: https://github.com/ChoGGi/SurvivingMars_CheatMods/blob/master/Mods ChoGGi/Fix Tourism Rockets/Code/Script.lua#L53


Sorry, I'll try to remember to do bug reports less codey, for some reason I thought you knew lua?

 

[ChoGGi_2]

Looks like it might be breaking a couple of them?

https://www.reddit.com/r/SurvivingMars/comments/ocse8b

His log also has a "[LUA ERROR] Mars/Lua/Buildings/RocketTrade.lua:71: attempt to call a nil value (field 'OnModifiableValueChanged')"

 

[AndrewT]

Thanks for that! I've logged a bug on that now and used all your material above to illustrate it.