Surviving Mars - Missing code from Residence:IsSuitable(colonist)

[SkiRich]

Description
Missing code from Residence:IsSuitable(colonist)
Windows
SteamWhat is your game version?
1001539Do you have Space Race installed?
YesPlease explain your issue is in as much detail as possible.
Adults are occupying buildings that have the children_only = true parameter.
Nurseries are the big ones everyone notices.
I traced this to a change that was made in the code for Residence:IsSuitable(colonist)
There is no longer a check for children. Instead is was replaced with some exclusivity code.

So I combined the old code with your new code and made a mod to fix this.
You may want to revisit that code
Mod is here ...

Steam Workshop::Fix Children Only Bldgs

steamcommunity.com

Can you replicate the issue?
It affects everyone. Folks on the forums are complaining.Attachments
File(s) attached

 

[SkiRich]

I updated the mod to add a routine to test all colonists once, in a save game for missing age traits in the regular trait table and fix that per colonist.
What is also going on is folks with save games prior to your hotfix that fixed that have colonists running around with no age traits in the traits table.

The filter system based on age is not working as a side effect and folks are not understanding why.

So when you guy put out a hotfix that changes or repairs thinigs like this, please add savegamefixup routines to retro fix any asset that may be flawed.

 

[AndrewT]

@Aiwyth have you got this one? Or did you want me to log it as a new bug?

 

[SkiRich]

Devs and @Aiwyth

I found another spot where the code is missing consideration for children only.

Old code:
function Residence:CanReserveResidence(unit)
if self.children_only and not unit.traits.Child then
return false
end
return self.reserved[unit] or self:GetFreeSpace() > 0
end

New code missing the check:
function Residence:CanReserveResidence(unit)
if self.exclusive_trait and not unit.traits[self.exclusive_trait] then
return false
end
return self.reserved[unit] or self:GetFreeSpace() > 0
end

 

[Aiwyth]

Thanks for this! I'm going to check if this was already flagged