Home Trending Latest threads New posts Developer diaries

The Validator - Find errors quickly and with minimal pain!

Jump to latest Follow Reply
  • We have updated our Community Code of Conduct. Please read through the new rules for the forum that are an integral part of Paradox Interactive’s User Agreement.
Crusader Kings II 69948 Bug Reports 19720 User Modifications 10606 Suggestions 5969 Tech Support 6376 After Action Reports
Show only dev responses
Reader mode
@Jamie550 Have you considered migrating The Validator to .Net Core 2.0? This would allow users to run it on *nix, as well as Windows. I've migrated a half-dozen or so projects from Framework 4.6 to Core 2.0 (or Standard 2.0, in some cases) and it's not terribly difficult. You would have to make some considerations in regards to differences in file systems (and timezones, but I don't imagine you do much with those).
 
NoxBestia said:
Thank you for adding the new ignore duplicates flags for me. Unfortunately, they are not working and I am still getting all the duplicate warnings I was.
Click to expand...
Do other ValidatorSettings work for you? Can you copy the exact errors here?

theStormWeaver said:
@Jamie550 Have you considered migrating The Validator to .Net Core 2.0? This would allow users to run it on *nix, as well as Windows. I've migrated a half-dozen or so projects from Framework 4.6 to Core 2.0 (or Standard 2.0, in some cases) and it's not terribly difficult. You would have to make some considerations in regards to differences in file systems (and timezones, but I don't imagine you do much with those).
Click to expand...
UI is in WPF which is not I believe in standard or core. There is no CLI currently and due to the status of the project such a CLI wouldn't be added. So moving to Core/Standard wouldn't help much, ignoring the complexity of migration (which may not be too high, but given the project state wouldn't be worth paying).
 
Jamie550 said:
UI is in WPF which is not I believe in standard or core. There is no CLI currently and due to the status of the project such a CLI wouldn't be added. So moving to Core/Standard wouldn't help much, ignoring the complexity of migration (which may not be too high, but given the project state wouldn't be worth paying).
Click to expand...

*facepalm* Of course. I can't believe I didn't think of the UI.
 
Jamie550 said:
Do other ValidatorSettings work for you? Can you copy the exact errors here?

Most of the settings I use seem to work fine. The settings that don't appear to work are the ignore duplicate flags. Even the older events one still flags duplicates. Here is an example of what I get from the validator when I try to usurp event CK2's event id = 300:

Code: 
--- Error 1 of 1 ---
Duplicate ID: 300
[1]: events\birth_events.txt (2150, 2)
[2]: <mod>\events\zz_NoxDPA-override_events.txt (23, 2)
Click to expand...
 
This is a crazy minor nitpick, but would it be possible for errors found inside scripted triggers and effects to only show up once, rather than once for every place that uses them? It creates a lot of spam that can be hard to navigate.

edit: nevermind, I forgot that scripted effects and triggers capture their environment like closures. Maybe at least make it so dismissing one scripted trigger warning dismisses all similar ones?
 
Last edited:
NavigatorNebula said:
This is a crazy minor nitpick, but would it be possible for errors found inside scripted triggers and effects to only show up once, rather than once for every place that uses them? It creates a lot of spam that can be hard to navigate.

edit: nevermind, I forgot that scripted effects and triggers capture their environment like closures. Maybe at least make it so dismissing one scripted trigger warning dismisses all similar ones?
Click to expand...
Linking warnings would be rather too tricky given the current scope and support of the Validator.

ngppgn said:
So, it turns out that the game doesn't use at all revoke_allowed and ai_will_revoke in decisions and mods. Maybe a warning should be added so modders become aware of this and stop including that in new laws/decisions.
Click to expand...


Can you point to where this is stated if there is one?

Also what do you mean by "mods"? Is that just "laws"?

Not accepting these would be an easy fix though would be nice to get Paradox to remove them from base files first if they exist.
 
Jamie550 said:
Linking warnings would be rather too tricky given the current scope and support of the Validator.


Can you point to where this is stated if there is one?

Also what do you mean by "mods"? Is that just "laws"?

Not accepting these would be an easy fix though would be nice to get Paradox to remove them from base files first if they exist.
Click to expand...

Yes, I meant "laws" instead of "mods" in that bits, nd no, sadly it was not in a public forum post.
 
society_quest_event don't need a picture, like letter_event.
 
I'm getting this error on an event
--- Error 1 of 1 ---
At <mod>\events\mythos_events.txt [character_event\trigger\FROM] (Line 4036, column 3):
Invalid use of 'FROM': This scope has no FROM due to the fact that <mod>\common\on_actions\mythos_on_actions.txt [on_artifact_inheritance\events\MYTH.54] (Line 306, column 3) has no scope.

It appears to be claiming that on_artifact_inheritance has no scope, so I can't use FROM.
Per artifacts_script.info:
# Scopes: ROOT is the character, FROM is the artifact, FROMFROM is the old holder

Also:
--- Error 1 of 1 ---
At <mod>\events\mythos_WoL.txt [character_event\immediate\if\FROM] (Line 12013, column 4):
Invalid use of 'FROM': This scope has no FROM due to the fact that <mod>\common\on_actions\mythos_on_actions.txt [on_crusade_creation\random_events\100] (Line 233, column 3) has no scope.

Per events\on_action_events.txt:
# new_character is the targetted enemy
# ROOT is the religious head
# FROM is the attacked kingdom title
 
ngppgn said:
So, it turns out that the game doesn't use at all revoke_allowed and ai_will_revoke in decisions and mods. Maybe a warning should be added so modders become aware of this and stop including that in new laws/decisions.
Click to expand...

This is not a good suggestion. I don't care about existing revoke_allowed and I'm not going to waste time removing them. Now instead of a few errors in decisions, I have 648. That doesn't give a good overview and hides real issues.
What suggestion should've been was "ignore whether revoke stuff exists". They are not "invalid nodes" they just don't do anything.
 
vukica said:
This is not a good suggestion. I don't care about existing revoke_allowed and I'm not going to waste time removing them. Now instead of a few errors in decisions, I have 648. That doesn't give a good overview and hides real issues.
What suggestion should've been was "ignore whether revoke stuff exists". They are not "invalid nodes" they just don't do anything.
Click to expand...
I intentionally and with full awareness suggested for it to be a warning rather than an error (warning as in, non-fatal and silenceable with some application flag or setting). And I hope there's some configurable flags to disable such warnings as desired, but novice modders should certainly be made aware of such things as these, lest we have them wasting time on coding useless ai_will_revoke blocks.
 
Reader mode
You must log in or register to reply here.
Top Bottom
Back