Code:
#Spymaster swapping
character_event = {
id = CR.1003
hide_window = yes
is_triggered_only = yes
immediate = {
set_character_flag = swapping_councillors
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_spymaster
}
}
event_target:moving_councillor = { add_trait = clubfooted }
break = yes
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_chancellor
}
}
event_target:moving_councillor = {
remove_title = job_chancellor
clr_character_flag = is_chancellor
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_job_title = job_chancellor
set_character_flag = is_chancellor
}
}
}
This is an event I'm trying to write, targetting the liege. The second if does not seem to work and I don't understand why; in previous versions the remove_title = job_spymaster was outside of the if and it worked (there are more if for every other council job).
I don't think it's necessary, but if more context is needed, the event chain is used to find a good spymaster among council members and put him there.
That's the whole chain, triggered by a decision targetting the liege. The first two events worked fine in my tests.
Code:
namespace = CR
#Targeted decision to flag all councilors
character_event = {
id = CR.1001
hide_window = yes
is_triggered_only = yes
immediate = {
if = {
limit = { has_job_title = job_chancellor }
set_character_flag = is_chancellor
}
if = {
limit = { has_job_title = job_marshal }
set_character_flag = is_marshal
}
if = {
limit = { has_job_title = job_treasurer }
set_character_flag = is_treasurer
}
if = {
limit = { has_job_title = job_spymaster }
set_character_flag = is_spymaster
}
if = {
limit = { has_job_title = job_spiritual }
set_character_flag = is_spiritual
}
if = {
limit = { has_minor_title = title_councilmember_king }
set_character_flag = is_councilmember_king
}
if = {
limit = { has_minor_title = title_councilmember_emperor }
set_character_flag = is_councilmember_emperor
}
ROOT = { character_event = { id = CR.1002 } }
ROOT = { add_trait = immortal }
}
}
Code:
#Finding the best spymaster
character_event = {
id = CR.1002
hide_window = yes
is_triggered_only = yes
immediate = {
ROOT = {
random_voter = {
limit = {
can_be_spymaster_trigger = yes
opinion = {
who = ROOT
value > 24
}
}
preferred_limit = {
intrigue > 19
opinion = {
who = ROOT
value > 24
}
}
preferred_limit = {
opinion = {
who = ROOT
value > 24
}
intrigue > 14
}
preferred_limit = {
intrigue > 19
opinion = {
who = ROOT
value > 0
}
}
preferred_limit = {
opinion = {
who = ROOT
value > 0
}
intrigue > 14
}
preferred_limit = {
intrigue > 9
opinion = {
who = ROOT
value > 0
}
}
preferred_limit = {
opinion = {
who = ROOT
value > 0
}
ai_honor > -1
}
preferred_limit = {
opinion = {
who = ROOT
value > -20
}
ai_honor > -1
}
save_event_target_as = moving_councillor
ROOT = { character_event = { id = CR.1003 } }
}
}
}
}
Code:
#Spymaster swapping
character_event = {
id = CR.1003
hide_window = yes
is_triggered_only = yes
immediate = {
set_character_flag = swapping_councillors
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_spymaster
}
}
event_target:moving_councillor = { add_trait = clubfooted }
break = yes
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_chancellor
}
}
event_target:moving_councillor = {
remove_title = job_chancellor
clr_character_flag = is_chancellor
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_job_title = job_chancellor
set_character_flag = is_chancellor
}
}
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_marshal
}
}
event_target:moving_councillor = {
remove_title = job_marshal
clr_character_flag = is_marshal
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_job_title = job_marshal
set_character_flag = is_marshal
}
}
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_treasurer
}
}
event_target:moving_councillor = {
remove_title = job_treasurer
clr_character_flag = is_treasurer
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_job_title = job_treasurer
set_character_flag = is_treasurer
}
}
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_spiritual
}
}
event_target:moving_councillor = {
remove_title = job_spiritual
clr_character_flag = is_spiritual
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_job_title = job_spiritual
set_character_flag = is_spiritual
}
}
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_councilmember_king
}
}
event_target:moving_councillor = {
remove_title = title_councilmember_king
clr_character_flag = is_councilmember_king
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_minor_title = title_councilmember_king
set_character_flag = title_councilmember_king
}
}
}
if = {
limit = {
event_target:moving_councillor = {
has_character_flag = is_councilmember_emperor
}
}
event_target:moving_councillor = {
remove_title = title_councilmember_emperor
clr_character_flag = is_councilmember_emperor
}
ROOT = {
job_spymaster = {
remove_title = job_spymaster
clr_character_flag = is_spymaster
give_minor_title = title_councilmember_emperor
set_character_flag = title_councilmember_emperor
}
}
}
event_target:moving_councillor = {
give_job_title = job_spymaster
set_character_flag = is_spymaster
}
clr_character_flag = is_chancellor
clr_character_flag = is_marshal
clr_character_flag = is_treasurer
clr_character_flag = is_spymaster
clr_character_flag = is_spiritual
clr_character_flag = is_councilmember_king
clr_character_flag = is_councilmember_emperor
clr_character_flag = swapping_councillors
}
}
First, what do you mean by targeting the liege? In a targeted decision, you right-click on a character's portrait and select an action to do them. That wording implies that this is meant to be done
by a vassal, triggering his liege to change a council title.
This could just be a case of mixed-up terminology, but I bring it up just in case it means something funky is going on.
Second, at the end of your code, all of the
clr_character_flag commands (
except for the last one,
swapping_councillors) seem meaningless, because they're all inside the ROOT scope, rather than any councilor scopes, and as far as I can tell, ROOT is the liege of the councilors. This shouldn't be affecting anything, because it's telling the game to remove flags from someone who apparently wouldn't have any of those flags to begin with, but it's a waste of code.
Third, the default scope of an event is by definition ROOT, so nesting a ROOT inside the event's default scope is redundant. This
shouldn't actually cause a problem, but at times CK2's code parsing will be wonky, and I think I have had issues in the past where the game doesn't correctly parse a redundant ROOT.
Fourth. From the code of CR.1001, it looks like it's meant to be happening to a councillor, due to its searching for councilor-relevant flags. Is that right? However, CR.1002 looks like it's meant to be happening to a liege, since it checks his own voters. However, at the end of CR.1001, you call CR.1002 to happen to the ROOT of CR.1001 - which in this case is the councilor. It seems like you'd want to replace
ROOT = { character_event = { id = CR.1002 } }
with
liege = { character_event = { id = CR.1002 } }
As you might expect,
liege scopes to a character's direct liege, and I think this is what you want.
However, note that
ROOT = { character_event = { id = CR.1003 } } at the end of CR.1002
is in fact correct. It's nested inside the
random_voter scope, and you clearly want CR.1003 to be firing for the voter's liege, so in this case, you do want to scope back to ROOT for that. I point that out, since I noted that a lot of the other ROOTs are redundant, and I want to be clear that this ROOT in particular is not redundant.
Now, for CR.1003, maybe I'm reading this incorrectly, but it looks like that only one councillor in each block is getting a new position, while the other one just has their position removed and doesn't get a new position in its place.
Those are all the things that I've spotted, there may be more that I missed.
